Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEA-3713 #52

Merged
merged 61 commits into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
c68ab1a
adds url variable defaults to blank
natasafrgk Jan 22, 2024
9142280
adds pr id in yaml
natasafrgk Jan 22, 2024
214959a
changes env value
natasafrgk Jan 22, 2024
d148166
edits request_ping
natasafrgk Jan 22, 2024
fed9f1f
changes environment variables
natasafrgk Jan 23, 2024
9d21759
removes logging for pr id
natasafrgk Jan 23, 2024
68005b4
creates def to handle pr id suffix
natasafrgk Jan 23, 2024
37a2096
creates condition for the env in workflow
natasafrgk Jan 23, 2024
83d8e5c
creates condition for the env in workflow
natasafrgk Jan 23, 2024
0d740cd
creates condition for the env in workflow
natasafrgk Jan 23, 2024
6984853
creates condition for the env in workflow
natasafrgk Jan 23, 2024
a8a1d0c
creates condition for the env in workflow
natasafrgk Jan 23, 2024
e9b0c6f
creates condition for the env in workflow
natasafrgk Jan 23, 2024
42a8d21
creates condition for the env in workflow after environment
natasafrgk Jan 23, 2024
5797fb8
creates condition for the env in workflow after environment with assi…
natasafrgk Jan 23, 2024
98f3795
creates condition for the env in workflow in reg test step with assig…
natasafrgk Jan 23, 2024
876c3fc
removes changes
natasafrgk Jan 23, 2024
c144cea
removes changes in envrionment py
natasafrgk Jan 23, 2024
cc56f6a
reverts deletion
natasafrgk Jan 23, 2024
9dfca7a
Merge remote-tracking branch 'origin' into AEA-3713
natasafrgk Jan 23, 2024
e31b95c
tries again with tennary op
natasafrgk Jan 23, 2024
baf8b85
tries again with tennary op and hardcoded default
natasafrgk Jan 23, 2024
8db30e7
tries again with tennary op with if before environment
natasafrgk Jan 23, 2024
e902a50
tries with separate if
natasafrgk Jan 23, 2024
0ebbe28
adds condition to before all
natasafrgk Jan 23, 2024
d3368d4
adds condition back into job
natasafrgk Jan 23, 2024
aa2f640
adds extra step to evaluate inputs
natasafrgk Jan 23, 2024
e40b636
edits step
natasafrgk Jan 23, 2024
e6b3ea9
edits step
natasafrgk Jan 23, 2024
84d56ca
edits step
natasafrgk Jan 23, 2024
5c01c94
reverts yaml
natasafrgk Jan 23, 2024
130aaa3
removes mention of eps pr id
natasafrgk Jan 23, 2024
cb5c8de
reverts environment py
natasafrgk Jan 23, 2024
60dd070
creates a new condition
natasafrgk Jan 23, 2024
2c4a1ff
creates a step
natasafrgk Jan 23, 2024
519559f
changes run
natasafrgk Jan 23, 2024
1e6bc81
adds pseudocode
natasafrgk Jan 23, 2024
b4454af
Merge branch 'main' into AEA-3713
seansteberisal Jan 24, 2024
8c0cb1b
edits script to select env
natasafrgk Jan 24, 2024
e754b38
Merge branch 'AEA-3713' of https://github.com/NHSDigital/electronic-p…
natasafrgk Jan 24, 2024
2b05f80
added "env" to before all from context userdata
seansteberisal Jan 24, 2024
e6c7341
removes mention of base url
natasafrgk Jan 24, 2024
c4644da
removes safe net for baseurl
natasafrgk Jan 24, 2024
279c39a
changes dict method
natasafrgk Jan 24, 2024
5d3b76d
convert to behave cmd line for env
natasafrgk Jan 24, 2024
05d94ce
changes dict method
natasafrgk Jan 24, 2024
fee7330
not using .env file anymore
seansteberisal Jan 24, 2024
99c2354
reworked if logic for internal-dev pr branches
seansteberisal Jan 24, 2024
d5c97ce
pre-commit jobs run
seansteberisal Jan 24, 2024
c1d0267
renamed DEV_BASE_URL to INTERNAL_DEV_BASE_URL
seansteberisal Jan 26, 2024
950f396
added print to see which URL the ping request is going to
seansteberisal Jan 26, 2024
aa49998
Merge branch 'main' into AEA-3713
seansteberisal Jan 26, 2024
6ea4484
poetry.lock
seansteberisal Jan 26, 2024
0d6b074
remove poetry-dotenv-plugin
seansteberisal Jan 26, 2024
529c1ca
added more base urls
seansteberisal Jan 26, 2024
26c2a11
changed _ to - in baseURL constant names
seansteberisal Jan 26, 2024
593d59d
Added a couple of comments to remind us to change the way we handle U…
seansteberisal Jan 26, 2024
5c992fa
black formatting
seansteberisal Jan 26, 2024
6874ca6
append pr- only if pr- wasn't already provided
seansteberisal Jan 29, 2024
0504643
Merge branch 'main' into AEA-3713
seansteberisal Jan 29, 2024
0249e06
fixed merge conflict
seansteberisal Jan 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion features/environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,12 @@ def is_debug(context):


def build_pull_request_id():
pr_suffix = f"-pr-{PULL_REQUEST_ID}" if PULL_REQUEST_ID else ""
pr_suffix = ""
if PULL_REQUEST_ID:
if "pr-" in str({PULL_REQUEST_ID}):
pr_suffix = f"-{PULL_REQUEST_ID}"
else:
pr_suffix = f"-pr-{PULL_REQUEST_ID}"
return pr_suffix


Expand Down
3 changes: 1 addition & 2 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.