Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM-6061 + CCM-6075 Content changes #50

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

jakecosgrove
Copy link
Contributor

Description

Stakeholder review content changes from the following tickets:

Context

Before an invite only release of the website, senior stakeholders were invited to leave feedback on the site for sign-off.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@jakecosgrove jakecosgrove requested a review from a team as a code owner August 8, 2024 08:56
…page. Moved some pages into different subsections in 'Using NHS Notify'.
emmagifford
emmagifford previously approved these changes Aug 8, 2024
Copy link
Contributor

@emmagifford emmagifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and address stakeholders' comments. I tweaked the landing page wording from 'free-text templates' to 'free-text messages'. Swapped the subsections of some of the pages in 'Using NHS Notify'.

…d page /using-nhs-notify/links-and-urls
Copy link
Contributor

@emmagifford emmagifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already reviewed this, we just needed Jake to submit a new PR because I made minor additional edits as part of my approval. Hopefully this will merge the changes.

@jakecosgrove jakecosgrove merged commit 41a3d5e into main Aug 12, 2024
24 checks passed
@jakecosgrove jakecosgrove deleted the CCM-6061-Landing-page---stakeholder-changes branch August 12, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants