MPAS applications: fixes for absolute vorticity and surface latent-heat flux #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymes-kenyon
changed the title
|
@gspetro-NOAA @FernandoAndrade-NOAA You may start the UPP RTs on R&D machines. There should be no baseline changes with this PR. |
|
The UPP RTs have been completed on WCOSS2 with no baseline changes. |
|
@jaymes-kenyon Please take a look at my UPP standalone test with MPAS_hfip data at |
|
@WenMeng-NOAA — Your test looks good—thanks for sharing! |
gspetro-NOAA
approved these changes
Oct 22, 2024
WenMeng-NOAA
approved these changes
Oct 22, 2024
|
This PR is ready for merging. |
WenMeng-NOAA
added
the
No Baseline Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1068. It has been tested in MPAS applications (GSL's RRFS and HFIP configurations).
(1) Fix for absolute vorticity: Currently, in INITPOST_MPAS.F, the U and V winds are interpolated (averaged) onto mass points without checking for missing values. However, for the HFIP domain, a region of missing values surrounds the computational domain. As a result, the UPP interpolation procedure at the domain edge is contaminated by adjacent "SPVAL" grid points. Moreover, the subsequent calculations involving horizontal U and V gradients (e.g., for absolute vorticity, or "ABSV") yield very large and "noisy" values at the domain edge. The GRIB2 compression struggles with these "ABSV" fields; see attached screenshot of 850-hPa absolute vorticity (left panel).
This PR ensures that U and V winds are interpolated onto mass points only after checking for the presence of "SPVAL" at adjacent grids. Additionally, the "ABSV" arrays are initialized with "SPVAL", regardless of MODELNAME. The corrected field of 850-hPa absolute vorticity is shown in the attached screenshot (right panel).
(2) Fix for surface latent-heat flux: This field is now read-in from the netCDF "LH" array