Thompson-Eidhammer microphysics code formatting #740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR points to changes to Thompson-Eidhammer microphysics ->
This PR is the first of many that will modernized, modularize, and streamline Thompson-Eidhammer microphysics.
This PR includes:
The addition of parameterized kind: REAL -> real(kind_phys)
Consistent indentation
Removal of GOTO statements
Description: Above
Issue(s) addressed: Formatting
Testing
How were these changes tested? The changes were tested on Hera.
What compilers / HPCs was it tested with? It was tested with Inte compilers on Hera.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes.
Have the ufs-weather-model regression test been run? On what platform? Yes, the ufs-weather-model regression test for P8 and RRFS been run on Hera.
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
No
Please commit the regression test log files in your ufs-weather-model branch
Dependencies
Do PRs in upstream repositories need to be merged first? No.