[production/RRFS.v1] Thompson-Eidhammer microphysics code formatting #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2024
|
@MatthewPyle-NOAA @jkbk2004 This is ready for review and merge. |
|
@MatthewPyle-NOAA let me know if you want me to merge with commit message cleanup. |
|
@jkbk2004 I can handle it - thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is @AndersJensen-NOAA work. This PR replaces #740 and is targeted at the RRFS release branch.
This PR points to changes to Thompson-Eidhammer microphysics ->
This PR is the first of many that will modernized, modularize, and streamline Thompson-Eidhammer microphysics.
This PR includes:
The addition of parameterized kind: REAL -> real(kind_phys)
Consistent indentation
Removal of GOTO statements
Adding metadata for physical constants needed by Thompson MP
Issue(s) addressed
None
Testing
See ufs-community/ufs-weather-model#2161
Dependencies
ufs-community/ccpp-physics#179