enable hybrid ghx #509
Merged
enable hybrid ghx #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Bill-Becker I added the central plant inputs/outputs but can't get the tests to run. Not sure if this is the same issue Amanda was seeing? |
This reverts commit d2df438.
add heat_pump_configuration field to ghpghx_responses
Bill-Becker
approved these changes
Sep 30, 2023
|
@rathod-b I just changed "Major Updates" to "Minor Updates" in the Changelog; no need to wait for the tests again before merging. |
Looks like there are missing model fields for GHPGHXInputs model for central plant, e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
Features (2)
What is the current behavior?
(You can also link to an open issue here)
At present, user is unable to access hybrid GHX or centralized GHP capabilities built in REopt.
What is the new behavior (if this is a feature change)?
User is able to access hybrid GHX and centralized GHP capabilities built in REopt.jl
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
If user is missing some inputs required by GHP tech (like heat_pump_configuration) their GHPGHX responses might fail.
Other information: