Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Photonics simulator get_ state #2283

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Fix Photonics simulator get_ state #2283

merged 6 commits into from
Oct 17, 2024

Conversation

Omar-ORCA
Copy link
Contributor

No description provided.

@Omar-ORCA
Fix get_state
965af22 
Signed-off-by: Omar Bacarreza <[email protected]>
@Omar-ORCA
Remove unused functions
7da5534 
Signed-off-by: Omar Bacarreza <[email protected]>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 15, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Omar-ORCA Omar-ORCA mentioned this pull request Oct 15, 2024
Closed
@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Oct 15, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Oct 16, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@khalatepradnya khalatepradnya enabled auto-merge (squash) October 16, 2024 23:24
@khalatepradnya khalatepradnya enabled auto-merge (squash) October 16, 2024 23:26
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Oct 17, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@khalatepradnya khalatepradnya merged commit 6a370c9 into NVIDIA:main Oct 17, 2024
132 checks passed
copy-pr-bot bot pushed a commit that referenced this pull request Oct 17, 2024
@Omar-ORCA @khalatepradnya @annagrin
Fix Photonics simulator get_ state (#2283)
0120c84 
* Fix `get_state`

Signed-off-by: Omar Bacarreza <[email protected]>

* Remove unused functions

Signed-off-by: Omar Bacarreza <[email protected]>

* Code formatting

Signed-off-by: Pradnya Khalate <[email protected]>

---------

Co-authored-by: Pradnya Khalate <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
@bettinaheim bettinaheim added the no release notes Don't list this PR in the release notes label Nov 19, 2024
@bettinaheim bettinaheim added this to the release 0.9.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalatepradnya khalatepradnya khalatepradnya approved these changes

Assignees
No one assigned
Labels
no release notes Don't list this PR in the release notes
Projects
None yet
Milestone
release 0.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Omar-ORCA @khalatepradnya @bmhowe23 @bettinaheim