-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for the braket target with Python frontend #2401
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7c88dc
to
cfe5c12
Compare
schweitzpgi
reviewed
Nov 22, 2024
bettinaheim
reviewed
Nov 22, 2024
bettinaheim
reviewed
Nov 22, 2024
schweitzpgi
reviewed
Nov 22, 2024
Signed-off-by: Pradnya Khalate <[email protected]>
* Two more tests working Signed-off-by: Pradnya Khalate <[email protected]>
* Additional tests Co-authored-by: Eric Schweitz <[email protected]> Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
* Test for asynchronous sampling API * Failing test for observe API * More tests to cover all native gates, custom operations * One more test - check kernel that takes arguments Signed-off-by: Pradnya Khalate <[email protected]>
not supported. * Simplify test setup since mock server isn't being used. Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Co-authored-by: Bettina Heim <[email protected]> Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Co-authored-by: Eric Schweitz <[email protected]> Signed-off-by: Pradnya Khalate <[email protected]>
47943f3
to
69a0277
Compare
the existing 'SToR1' and 'TToR1' are sufficient * Disable 'R1toU3' pattern on all pipelines * Clean -up comments Signed-off-by: Pradnya Khalate <[email protected]>
6a1fb9c
to
db0b361
Compare
bettinaheim
reviewed
Nov 25, 2024
Signed-off-by: Pradnya Khalate <[email protected]>
* Simpler command-line invocation in test Signed-off-by: Pradnya Khalate <[email protected]>
e1ce056
to
e33f2a8
Compare
bmhowe23
reviewed
Nov 25, 2024
Co-authored-by: Ben Howe <[email protected]> Signed-off-by: Pradnya Khalate <[email protected]>
annagrin
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks Pradnya!
Signed-off-by: Pradnya Khalate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the support for the
braket
target with Python frontend, started in #2379.