Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the braket target with Python frontend #2401

Merged
merged 19 commits into from
Nov 26, 2024

Conversation

khalatepradnya
Copy link
Collaborator

@khalatepradnya khalatepradnya commented Nov 21, 2024

Completes the support for the braket target with Python frontend, started in #2379.

@khalatepradnya khalatepradnya marked this pull request as ready for review November 21, 2024 21:33
@khalatepradnya khalatepradnya self-assigned this Nov 21, 2024
@khalatepradnya khalatepradnya enabled auto-merge (squash) November 21, 2024 23:50
python/tests/backends/test_braket.py Show resolved Hide resolved
python/tests/backends/test_braket.py Outdated Show resolved Hide resolved
python/tests/backends/test_braket.py Show resolved Hide resolved
python/tests/backends/test_braket.py Outdated Show resolved Hide resolved
python/tests/backends/test_braket.py Outdated Show resolved Hide resolved
python/tests/backends/test_braket.py Show resolved Hide resolved
python/tests/backends/test_braket.py Show resolved Hide resolved
python/tests/backends/test_braket.py Show resolved Hide resolved
python/tests/backends/test_braket.py Show resolved Hide resolved
khalatepradnya and others added 13 commits November 22, 2024 16:34
* Two more tests working

Signed-off-by: Pradnya Khalate <[email protected]>
* Additional tests

Co-authored-by: Eric Schweitz <[email protected]>

Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
* Test for asynchronous sampling API
* Failing test for observe API
* More tests to cover all native gates, custom operations
* One more test - check kernel that takes arguments

Signed-off-by: Pradnya Khalate <[email protected]>
  not supported.
* Simplify test setup since mock server isn't being used.

Signed-off-by: Pradnya Khalate <[email protected]>
Co-authored-by: Bettina Heim <[email protected]>

Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Co-authored-by: Eric Schweitz <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
  the existing 'SToR1' and 'TToR1' are sufficient
* Disable 'R1toU3' pattern on all pipelines
* Clean -up comments

Signed-off-by: Pradnya Khalate <[email protected]>
Co-authored-by: Ben Howe <[email protected]>

Signed-off-by: Pradnya Khalate <[email protected]>
Copy link
Collaborator

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks Pradnya!

@khalatepradnya khalatepradnya merged commit d09471d into NVIDIA:main Nov 26, 2024
213 checks passed
@khalatepradnya khalatepradnya deleted the braket-fixes branch November 26, 2024 18:04
@bettinaheim bettinaheim changed the title [braket] Python tests Support for the braket target with Python frontend Dec 10, 2024
@bettinaheim bettinaheim added the enhancement New feature or request label Dec 10, 2024
@bettinaheim bettinaheim added this to the release 0.9.1 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants