EKIR-193 Add extra fields and more #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extra fields, device model, software version and book name and a description text for users. Also read the server and port from .env, clean up the imports a bit, move away from user and password based auth. Refs EKIR-193
natlibfi-max-grasbeck
force-pushed
the
new-fields
branch
2 times, most recently
from
b0878b6 to
4d04404
Compare
Refs EKIR-191
natlibfi-max-grasbeck
force-pushed
the
new-fields
branch
from
4d04404 to
3084a20
Compare
kankaristo
suggested changes
Jun 3, 2024
Add support for fields like device_manufacturer, version_name, version_code and commit. Also includes some template stuff that mostly just ensures scrolling works with extra fields. Refs EKIR-191
natlibfi-max-grasbeck
force-pushed
the
new-fields
branch
from
31632bb to
242bf91
Compare
kankaristo
approved these changes
Jun 3, 2024
|
Looks good to me, but I only read the code, I haven't tried running/testing this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra fields, device model, software version and book name and a description text for users.
Also read the server and port from .env, clean up the imports a bit, move away from user and password based auth.
Refs EKIR-193