Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate minimum distance between two GeoFeatures #46

Open
wants to merge 2 commits into
base: hexy
Choose a base branch
from

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Dec 12, 2022

Adds a minimum-distance-of function to the NetLogo GIS Extension.

This combines #17, #18 and #19, originally written by @josephzhao.

Adds a minimum-distance-of function to the NetLogo GIS Extension

Co-Authored-By: josephzhao <[email protected]>
Copy link
Contributor

@LaCuneta LaCuneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for pulling this together. Unfortunately when I went to compile it I found a bunch of syntax errors in the code. As such I suspect this may not actually work as I don't think the author could've actually tested it, but I may be wrong. I left comments on the code issues.

Other things I'd want to see before merging:

If you get things working just let me know and I'll be happy to re-test and merge.

src/org/myworldgis/netlogo/GISExtension.java Outdated Show resolved Hide resolved
src/org/myworldgis/netlogo/VectorDataset.java Outdated Show resolved Hide resolved
src/org/myworldgis/netlogo/VectorDataset.java Show resolved Hide resolved
src/org/myworldgis/netlogo/VectorFeature.java Outdated Show resolved Hide resolved
src/org/myworldgis/netlogo/VectorFeature.java Outdated Show resolved Hide resolved
@EwoutH
Copy link
Contributor Author

EwoutH commented Dec 14, 2022

Thanks a lot for the quick and extensive reply. I fixed the cases you mentioned in the review in 34a1ecb.

Unfortunately, I'm not a Java dev (and to be honest, not thinking of becoming one), so further development and testing is difficult for me. So this is probably as far as I can get this PR. Maybe @josephzhao is still interested in finishing what he started, or you or someone else want to finish it.

I've checked the "Allow edits by maintainers" checkbox on this PR. I also think you can go to https://github.dev/NetLogo/GIS-Extension/pull/46 (notice the .dev) and add commits to this PR. And otherwise, (anyone) feel fully free to take the patch of this PR and build on from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants