-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Readme: CR Methods citation, and Slack badge #59
Conversation
rgutzen
commented
Feb 8, 2024
- Replacing the arxiv citation with the CR Methods citation.
- Adding a badge to join the Cobrawap Slack
.. image:: https://img.shields.io/badge/slack-join-pink.svg | ||
:target: https://join.slack.com/t/cobrawapworkinggroup/shared_invite/zt-1t8fjv447-64MrlHywww97LRC1ZtW0DA | ||
:alt: Join our Slack Community | ||
:align: left |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:align: left | |
:align: right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if "align left" would work when displayed on screen, because there are three banners in the same line now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alignment to the left for all the elements has the effect that they are listed one after the other from left to right. You can see the rendered version of the README on the fork branch.
However, it seems that the displayed order (doi, slack, docs) is not the same as in the rst code (docs, doi, slack). I'm not sure how the display order is determined then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see your fork branch (I see there are 14 forks, but just mine is visible to me); my preview of the .rst code here in the github review tool shows the "slack" banner in a new line, below the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a link just below the PR Title.
https://github.com/rgutzen/cobrawap/tree/docs/readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull request approved, just a minor comment/suggestion added (line 18), but I guess we can easily change it afterwords/at the next pull request
Wait with merge until after hotfix. |