Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme: CR Methods citation, and Slack badge #59

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

rgutzen
Copy link
Collaborator

@rgutzen rgutzen commented Feb 8, 2024

  • Replacing the arxiv citation with the CR Methods citation.
  • Adding a badge to join the Cobrawap Slack

.. image:: https://img.shields.io/badge/slack-join-pink.svg
:target: https://join.slack.com/t/cobrawapworkinggroup/shared_invite/zt-1t8fjv447-64MrlHywww97LRC1ZtW0DA
:alt: Join our Slack Community
:align: left
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:align: left
:align: right

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if "align left" would work when displayed on screen, because there are three banners in the same line now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment to the left for all the elements has the effect that they are listed one after the other from left to right. You can see the rendered version of the README on the fork branch.
However, it seems that the displayed order (doi, slack, docs) is not the same as in the rst code (docs, doi, slack). I'm not sure how the display order is determined then.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see your fork branch (I see there are 14 forks, but just mine is visible to me); my preview of the .rst code here in the github review tool shows the "slack" banner in a new line, below the others

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a link just below the PR Title.
https://github.com/rgutzen/cobrawap/tree/docs/readme

Copy link
Collaborator

@gulpgiulia gulpgiulia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull request approved, just a minor comment/suggestion added (line 18), but I guess we can easily change it afterwords/at the next pull request

@mdenker
Copy link
Member

mdenker commented Feb 22, 2024

Wait with merge until after hotfix.

@mdenker
Copy link
Member

mdenker commented May 22, 2024

Merge as soon as version number is increased, e.g., after #62 #63

@mdenker mdenker merged commit 364ddd5 into NeuralEnsemble:master Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants