Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: build an image with compiled toolchain #36

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

NickVolynkin
Copy link
Contributor

@NickVolynkin NickVolynkin commented Mar 1, 2023

docker: build an image with compiled toolchain

  • Build an image with compiled toolchain:
    ghcr.io/nilfoundation/proof-market-toolchain:latest.
    It has everything to start working with the toolchain right away.
    Releases are made from a secured machine, not CI.
    However, the image is built on each commit to check that it stays
    buildable.

  • Use a base build image with dependencies, including Boost 1.76.0.
    Using the base image speeds up builds a lot.

  • Update readme. Encourage users to take the :latest image rather
    than build it themselves when they just need to use the toolchain.

  • Renew build instructions: now git operations, dependencies, and build
    instructions for two different modes are grouped together.

ci: turn off hadolint check

Hadolint check in its current form is hard to reproduce on local machine
and unstable, because it doesn't have a way to fix version and specify
checked files.

Will rebuild it in #65

Resolve #35
Resolve #38

@NickVolynkin NickVolynkin changed the title docker: reduce image size, reformat Dockerfile docker: push image to GitHub registry Mar 1, 2023
@NickVolynkin NickVolynkin force-pushed the 35-push-docker-image branch 28 times, most recently from 43f14d4 to 7f7482f Compare June 3, 2023 12:30
@NickVolynkin NickVolynkin force-pushed the 35-push-docker-image branch from 7f7482f to cae4312 Compare June 5, 2023 15:30
@NickVolynkin NickVolynkin force-pushed the 35-push-docker-image branch from 488340e to 89929c7 Compare June 15, 2023 15:18
@NickVolynkin NickVolynkin force-pushed the 35-push-docker-image branch 4 times, most recently from 4ab7f50 to a886cc7 Compare June 16, 2023 10:42
@NickVolynkin NickVolynkin changed the title docker: push image to GitHub registry docker: build an image with compiled toolchain Jun 16, 2023
@NickVolynkin NickVolynkin force-pushed the 35-push-docker-image branch 2 times, most recently from 12de5ce to 0d02356 Compare June 16, 2023 17:32
@NickVolynkin NickVolynkin marked this pull request as ready for review June 16, 2023 17:33
@NickVolynkin NickVolynkin force-pushed the 35-push-docker-image branch 3 times, most recently from 406cbc9 to ff20ebb Compare June 19, 2023 08:53
README.md Outdated Show resolved Hide resolved
@NickVolynkin NickVolynkin force-pushed the 35-push-docker-image branch from ff20ebb to 5752130 Compare June 19, 2023 13:28
* Build an image with compiled toolchain:
  `ghcr.io/nilfoundation/proof-market-toolchain:latest`.
  It has everything to start working with the toolchain right away.
  Releases are made from a secured machine, not CI.
  However, the image is built on each commit to check that it stays
  buildable.

* Use a base build image with dependencies, including Boost 1.76.0.
  Using the base image speeds up builds a lot.

* Update readme. Encourage users to take the `:latest` image rather
  than build it themselves when they just need to use the toolchain.

* Renew build instructions: now git operations, dependencies, and build
  instructions for two different modes are grouped together.

Resolve #35
Resolve #38
@NickVolynkin NickVolynkin force-pushed the 35-push-docker-image branch from 5752130 to f8d7f77 Compare June 19, 2023 13:33
Hadolint check in its current form is hard to reproduce on local machine
and unstable, because it doesn't have a way to fix version and specify
checked files.

Will rebuild it in #65
@NickVolynkin NickVolynkin force-pushed the 35-push-docker-image branch from d330a4d to 2cf6d6f Compare June 20, 2023 12:30
@NickVolynkin NickVolynkin merged commit 0721c5a into master Jun 20, 2023
@NickVolynkin NickVolynkin deleted the 35-push-docker-image branch June 20, 2023 14:17
This was referenced Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure readme: prefer containerized workflow Publish a ready-to-work docker image
2 participants