bitwarden: 2023.9.0 -> 2023.9.3 #260699
Closed
bitwarden: 2023.9.0 -> 2023.9.3 #260699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
|
They released 2023.9.3, it still segfaults on exit so I guess that’s “expected behavior” for now while they fix more things. |
amarshall
force-pushed
the
bitwarden-update
branch
from
34fbd8a to
5dab9d0
Compare
amarshall
changed the title
| @@ -3,7 +3,7 @@ | |||
| , buildNpmPackage | |||
| @@ -26,7 +26,7 @@ let | |||
| icon = "bitwarden"; | |||
|
|
|||
| buildNpmPackage' = buildNpmPackage.override { nodejs = nodejs_18; }; | |||
| electron = electron_24; | |||
| electron = electron_25; | |||
|
|
|||
| desktopItem = makeDesktopItem { | |||
There was a problem hiding this comment.
Would be nice if we would use copyDekstopItems instead of manually copying it.
13 tasks
|
Here's a version with the requested changes cause I don't have permission to push to this branch: #262797 |
SuperSandro2000
approved these changes
Oct 22, 2023
|
@SuperSandro2000 That build error is due to bug in fetching NPM deps, fixed in #260011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff: bitwarden/clients@desktop-v2023.9.0...desktop-v2023.9.3
Changelog: https://github.com/bitwarden/clients/releases/tag/desktop-v2023.9.3
Description of changes
Things done
Note I have only tested execution when built against nixpkgs with glibc 2.38 backported, as that’s what my NixOS is running and trying to execute Bitwarden compiled against glibc 2.37 on a 2.38 runtime fails with glibc version mismatch.
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)