Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitwarden: 2023.9.0 -> 2023.9.3 #262797

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Oct 22, 2023

Description of changes

Diff: bitwarden/clients@desktop-v2023.9.0...desktop-v2023.9.3

Changelog: https://github.com/bitwarden/clients/releases/tag/desktop-v2023.9.3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

closes #260699

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already tested just the update commit and that worked thanks

pkgs/tools/security/bitwarden/default.nix Outdated Show resolved Hide resolved
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 22, 2023
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 22, 2023
@ofborg ofborg bot requested a review from Kiwi October 22, 2023 22:43
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 22, 2023
Copy link
Member

@amarshall amarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested build and that desktop entry is present in output still.

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 23, 2023
@dotlambda dotlambda merged commit 597baf8 into NixOS:master Oct 23, 2023
14 checks passed
@dotlambda dotlambda deleted the bitwarden-2023.9.3 branch October 23, 2023 05:46
@github-actions
Copy link
Contributor

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-262797-to-release-23.05 origin/release-23.05
cd .worktree/backport-262797-to-release-23.05
git checkout -b backport-262797-to-release-23.05
ancref=$(git merge-base 40f43be98117c4fe54a4e0fcf9b1a79aafe3d822 33981053289592b9fccc1c491dd385d47be26b90)
git cherry-pick -x $ancref..33981053289592b9fccc1c491dd385d47be26b90

@adingbatponder

This comment was marked as off-topic.

@luftmensch-luftmensch
Copy link
Contributor

luftmensch-luftmensch commented Oct 30, 2023

Hi @dotlambda, sorry for the ping.
It's possible to fix the the backport on 23.05, so there is no need to enable insicure package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants