bitwarden: use Electron 27 instead of 26 to fix bug #273861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
reviewed
Dec 13, 2023
There was a problem hiding this comment.
Can we apply bitwarden/clients@d766023 as patch and re-enable the version check?
ofborg
bot
added
11.by: package-maintainer
Seems to only occur on some GPUs, e.g. some Intel GPUs. See also bitwarden/clients#6560. Cannot go back to electron 25 easily due to NixOS#272912. Since upstream has a commit to do this, backport it (it does not apply cleanly, though, so vendor).
amarshall
force-pushed
the
bitwarden-fix-electron
branch
from
0b9d173 to
333dadb
Compare
|
@dotlambda Done and re-tested. |
|
|
|
@dotlambda No, because it conflicts, but the conflict is trivial (the dep right above it was removed on master). |
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to only occur on some GPUs, e.g. some Intel GPUs. See also bitwarden/clients#6560. Cannot go back to electron 25 easily due to
#272912.
Description of changes
Things done
Tested on amdgpu and i915
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.