Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-23.11] bitwarden: use Electron 27 instead of 26 to fix bug #274254

Merged
merged 1 commit into from
Dec 15, 2023
Merged

[Backport release-23.11] bitwarden: use Electron 27 instead of 26 to fix bug #274254

merged 1 commit into from
Dec 15, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 14, 2023 •
edited by NickCao
Loading

Bot-based backport to release-23.11, triggered by a label in #273861.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@amarshall @github-actions
bitwarden: use Electron 27 instead of 26 to fix bug
24b705b 
Seems to only occur on some GPUs, e.g. some Intel GPUs. See also
bitwarden/clients#6560. Cannot go back to
electron 25 easily due to
#272912.

Since upstream has a commit to do this, backport it (it does not apply
cleanly, though, so vendor).

(cherry picked from commit 333dadb)
@github-actions github-actions bot mentioned this pull request Dec 14, 2023
Merged
13 tasks
@ofborg ofborg bot requested review from Kiwi and amarshall December 14, 2023 17:19
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 14, 2023
amarshall
amarshall approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@amarshall amarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 14, 2023
@NickCao NickCao merged commit a7d2dc0 into release-23.11 Dec 15, 2023
9 of 10 checks passed
@emilylange emilylange deleted the backport-273861-to-release-23.11 branch December 20, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarshall amarshall amarshall approved these changes

@Kiwi Kiwi Awaiting requested review from Kiwi

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amarshall @delroth @NickCao