rapidcheck: Simplify installation, update, pkg-config #274297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
changed the title
We had neglected to nice `RC_INSTALL_ALL_EXTRAS`, which will take care of installing the "extras" for us. Now that they are in a standard directory, we don't need to smuggle in the extra `-I` for Nix's tests either.
Ericson2314
force-pushed
the
rapidcheck-simplify-install
branch
from
9def8c5 to
2b8c88f
Compare
Ericson2314
changed the title
Ericson2314
force-pushed
the
rapidcheck-simplify-install
branch
from
2b8c88f to
ffefc11
Compare
roberth
reviewed
Dec 15, 2023
The last update added pkg-config support. Co-authored-by: Robert Hensing <[email protected]>
Ericson2314
force-pushed
the
rapidcheck-simplify-install
branch
from
59900dc to
a7447f9
Compare
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.05
git worktree add -d .worktree/backport-274297-to-release-23.05 origin/release-23.05
cd .worktree/backport-274297-to-release-23.05
git switch --create backport-274297-to-release-23.05
git cherry-pick -x ab8cf01579ce0eba0202b0c84a71fd54ccfe4fc2 789df4b46d8c43e30999f8d41f52ab9149427b5b a7447f9e338fbaa12aeda5849041a39e04dd4b11 |
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Simplify installation
We had neglected to nice
RC_INSTALL_ALL_EXTRAS, which will take care of installing the extras for us.Now that they are in a standard directory, we don't need to smuggle in the extra
-Ifor Nix's tests either.Update
unstable-2023-04-16 -> unstable-2023-08-15
Add
meta.pkgConfigModulesand testThe last update added pkg-config support, from emil-e/rapidcheck#319
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.