Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-23.11] rapidcheck: Simplify installation, update, pkg-config #274925

Merged
merged 3 commits into from
Dec 17, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-23.11, triggered by a label in #274297.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

We had neglected to nice `RC_INSTALL_ALL_EXTRAS`, which will take care
of installing the "extras" for us.

Now that they are in a standard directory, we don't need to smuggle in
the extra `-I` for Nix's tests either.

(cherry picked from commit ab8cf01)
The last update added pkg-config support.

Co-authored-by: Robert Hensing <[email protected]>
(cherry picked from commit a7447f9)
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when greern

@roberth roberth removed the request for review from Ericson2314 December 17, 2023 08:15
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 17, 2023
@roberth roberth merged commit 1bd781a into release-23.11 Dec 17, 2023
25 checks passed
@emilylange emilylange deleted the backport-274297-to-release-23.11 branch December 20, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants