Upgrade puppeteer and other npm packages #1730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, so that's the exact same error as before 😅 Perhaps this has to do with the host machine that's running the tests. Let's see how we can address that. Will still try and merge this pull request later because it's nice to keep dependencies up to date. |
|
closing in favor of #1731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got a bug in our continuous integration tests related to our very out of date puppeteer version. This should fix it right up, which our tests will verify. I decided to just upgrade all of the npm packages at once, because why not?
contributes to https://linear.app/noredink/issue/FXN-3732/build-of-noredink-ui-failing