Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --no-sandbox flag for puppeteer tests #1731

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

derek-noredink
Copy link
Contributor

@derek-noredink derek-noredink commented Jan 31, 2025

Fixing a bug from our continuous integration tests. The version of linux that we're using results in a failure like this when running puppeteer:

[12805:12805:0131/221449.817395:FATAL:zygote_host_impl_linux.cc(128)] No usable sandbox! If you are running on Ubuntu 23.10+ or another Linux distro that has disabled unprivileged user namespaces with AppArmor, see https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md. Otherwise see https://chromium.googlesource.com/chromium/src/+/main/docs/linux/suid_sandbox_development.md for more information on developing with the (older) SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox.

Here's a stack overflow thread covering this topic: https://stackoverflow.com/questions/50662388/running-headless-chrome-puppeteer-with-no-sandbox

They say that running puppeteer with --no-sandbox is a security vulnerability. However, in our case we are only ever pointing puppeteer at a locally hosted server within the linux box, which means that there's no one at the other end to exploit the vulnerability.

--

In addition to fixing that bug, I also upgraded all of our npm packages (by merging in #1730), because that's what it took to make the puppeteer tests pass locally for me.

--

closing https://linear.app/noredink/issue/FXN-3732/build-of-noredink-ui-failing

Copy link

linear bot commented Jan 31, 2025

@derek-noredink derek-noredink added this pull request to the merge queue Feb 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2025
@caseyWebb caseyWebb added this pull request to the merge queue Feb 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2025
@caseyWebb caseyWebb added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit 47c96b2 Feb 3, 2025
7 checks passed
@caseyWebb caseyWebb deleted the derek/fix-github-actions-bug branch February 3, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants