Use --no-sandbox
flag for puppeteer tests
#1731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug from our continuous integration tests. The version of linux that we're using results in a failure like this when running puppeteer:
Here's a stack overflow thread covering this topic: https://stackoverflow.com/questions/50662388/running-headless-chrome-puppeteer-with-no-sandbox
They say that running puppeteer with
--no-sandbox
is a security vulnerability. However, in our case we are only ever pointing puppeteer at a locally hosted server within the linux box, which means that there's no one at the other end to exploit the vulnerability.--
In addition to fixing that bug, I also upgraded all of our npm packages (by merging in #1730), because that's what it took to make the puppeteer tests pass locally for me.
--
closing https://linear.app/noredink/issue/FXN-3732/build-of-noredink-ui-failing