Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Unown form notification #250

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

RobTwoThree
Copy link

Much like gender, pull Unown form and send to notifications. Does not
insert form into database and therefore does not display on web.py.
Works with PokeAlarm. Successfully tested with PokeAlarm.

RobTwoThree and others added 2 commits May 2, 2017 20:20
Much like gender, pull Unown form and send to notifications. Does not
insert form into database and therefore does not display on web.py.
Works with PokeAlarm.
@j16sdiz
Copy link
Contributor

j16sdiz commented Jun 5, 2017

Unown forms is availible on WildPokemon. You can do that without encounter.

@RobTwoThree
Copy link
Author

Updated to check for Unown "form" without requiring encounter and send to webhook. May consider closing this PR since PR #284 does the same thing. The difference is this only sends "form" for Unown. Difficult to test since Unown are ultra rare.

@RobTwoThree
Copy link
Author

@j16sdiz This may be true, however, the way form is being passed, it still requires it to be encountered. I tried it without encounter and Unown form wasn't being passed to PokeAlarm like it used to.

@j16sdiz
Copy link
Contributor

j16sdiz commented Jul 19, 2017

starnge, i have been running without encounter for a month and still have forms.
I have only changed normalize_pokemon and the notifcation.py

@RobTwoThree
Copy link
Author

@j16sdiz I believe its because there's a bug with ENCOUNTER = None, 'some', 'notify'. When I set ENCOUNTER = 'none' but still have notifications, it doesn't send form to webhook because all encounters are turned off. So I tried ENCOUNTER = 'some' and it still wouldn't send form. Only when I have ENCOUNTER = 'notify' does it send form and all encounter data on all in ALWAYS_NOTIFY_IDS. So we were left with all or none. I was able to patch the ENCOUNTER = 'some' bug and from there I was able to determine that form (and all encounter data) is only sent to webhook during encounter code because only normalized pokemon are sent to webhook which includes the form attribute. Its a bigger bug with what is being sent to webhook, but I think the patch fixes it for now.

RobTwoThree pushed a commit to RobTwoThree/Monocle that referenced this pull request Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants