Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Unown form via webhook #284

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

evenly-epic-mule
Copy link
Contributor

No description provided.

@baskettcase
Copy link

I have yet to see one! Heh

@tallypokemap
Copy link

Should this also be added to db and the frontend? @evenly-epic-mule

@RobTwoThree
Copy link

Has this been successfully tested with PokeAlarm for example? I know PR #250 works for sure but it was using encounter and only sending form to the webhook of Unown only.

@evenly-epic-mule
Copy link
Contributor Author

@tallypokemap actually yes, but I'm not sure how at best, because adding a new column for only one Pokemon is kind of a waste of resources

I think we should come up with a draft for some extra details like "XL Karp", "Unown Type", ...

@ghost
Copy link

ghost commented Jun 15, 2017

@tallypokemap @evenly-epic-mule PGScout branch has implemented Unown form (smallint column). The form gets sent as an INT to PA. PA doesn't convert the INT as of right now.

One column for a pokemon is a bit wasteful. Most values will be inserted as None/Null though.

@ghost
Copy link

ghost commented Jun 19, 2017

@Avatar690 Actually in brach 3.2 of PA Deadly has put in the capability for

DTS and it does convert the int.

@ghost
Copy link

ghost commented Jun 23, 2017

@ifindpokemons awesome. Ill have to fix my alarms!

Sent from my LGE LG-H820 using FastHub

RobTwoThree pushed a commit to RobTwoThree/Monocle that referenced this pull request Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants