Add missing pop_begin/pop_end for mapping types
#1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so bindings can be processed for files with using directives on mapping types without crashing.
|
OmarTawfik
reviewed
Dec 2, 2024
| @@ -850,6 +852,10 @@ inherit .lexical_scope | |||
|
|
|||
| ; resolve the value type through our scope | |||
| edge @value_type.type_ref -> @mapping.lexical_scope | |||
|
|
|||
| ; We use the value_type's definition path as our, although that's not correct | |||
There was a problem hiding this comment.
nit: missing part of the docs: "as our"?
OmarTawfik
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this additional required fix after merging #1159. This is so bindings can be processed for files with using directives on mapping types without crashing. We want to merge this before #1149 to get a meaningful baseline before those fixes are applied.