Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing pop_begin/pop_end for mapping types #1173

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Add missing pop_begin/pop_end for mapping types #1173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b546c7d
Add missing `pop_begin`/`pop_end` for mapping types
ggiraldez Nov 28, 2024
f4961a7
Fix and clarify comment
ggiraldez Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/solidity/inputs/language/bindings/rules.msgb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,6 +767,8 @@ inherit .lexical_scope
@type_name [TypeName @mapping [MappingType]] {
let @type_name.type_ref = @mapping.lexical_scope
let @type_name.output = @mapping.output
let @type_name.pop_begin = @mapping.pop_begin
let @type_name.pop_end = @mapping.pop_end
}


Expand Down Expand Up @@ -845,6 +847,12 @@ inherit .lexical_scope

; resolve the value type through our scope
edge @value_type.type_ref -> @mapping.lexical_scope

; We use the value_type's definition path as our own because it's needed when
; a mapping is the target of a `using` directive. It's not correct, but we
; don't have the analog referencing path either.
let @mapping.pop_begin = @value_type.pop_begin
let @mapping.pop_end = @value_type.pop_end
}


Expand Down
8 changes: 8 additions & 0 deletions crates/solidity/outputs/cargo/crate/src/generated/bindings/generated/binding_rules.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading