Add time attributes to be cdo/xr-conform #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaerz
added
enhancement
This was referenced Dec 12, 2024
|
@jmaerz - it has been a while since I looked into this file. Will need some time to test and see what is going on. |
TomasTorsvik
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
@jmaerz - looks good to me. Not sure why the date was defined as a global attribute in the first place.
JorgSchwinger
approved these changes
Dec 13, 2024
| @@ -827,7 +827,7 @@ subroutine write_netcdf(iogrp) | |||
| !--- Define global attributes | |||
| call nccheck(NF90_PUT_ATT(ncid,NF90_GLOBAL,'title','Global inventory for marine bgc') ) | |||
| call nccheck(NF90_PUT_ATT(ncid,NF90_GLOBAL,'history','Global inventory for marine bgc') ) | |||
| call nccheck(NF90_PUT_ATT(ncid,NF90_GLOBAL,'date', timeunits) ) | |||
| !call nccheck(NF90_PUT_ATT(ncid,NF90_GLOBAL,'date', timeunits) ) | |||
|
|
|||
There was a problem hiding this comment.
Could be deleted instead of commented out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @TomasTorsvik and @JorgSchwinger , when I was running some python-xarray routines to plot the netcdf-inventory written out by iHAMOCC, I realized that xarray had issues to interpret the time dimension correctly. Some attributes for the time dimension were missing, which I introduce with this PR. I hope it doesn't break any of your own post-processing pipelines - please check carefully and let me know.
@TomasTorsvik , since you have written this inventory part: please check carefully (also, whether the time is correctly set - I assumed that the previous global attribute
datewas linked to the time dimension).Only tested in single column mode. Limited idea, why the build fails here.