Adding the ability to create multiple CAN callbacks #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyldonahue
reviewed
Dec 14, 2023
platforms/stm32f405/include/can.h
Outdated
| } can_msg_t; | ||
|
|
||
| HAL_StatusTypeDef can_init(can_t *can); | ||
| HAL_StatusTypeDef can_init(can_t *can, can_callback_t callback); |
There was a problem hiding this comment.
why isnt the callback added to the struct so that we dont need the extra param?
There was a problem hiding this comment.
I figured it was just one param and the user doesn't particularly care about it inside the struct, definitely can pull from struct instead
dyldonahue
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we only were able to have 1 callback across all lines (i.e. global value), but now we are linking the callback to each hcan struct