Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General changes/improvements #151

Merged
merged 8 commits into from
Jan 25, 2025
Merged

Conversation

jr1221
Copy link
Contributor

@jr1221 jr1221 commented Jan 24, 2025

Changes

Some major changes. Includes a verification of wake logic, switching the structure of segment.c, as well as a bunch of other stuff. Verifies chip sleep does not occur. Increases SPI speed to 2mbps.

Notes

Any other notes go here

Test Cases

  • Case A
  • Edge case
  • ...

To Do

Any remaining things that need to get done

TODO overall for MVP test segment

  • Figure out S-ADC reading
  • Improve debug printing
  • improve aux/aux2 register stuff so they only read from the correct GPIOs.

TODO for 24A

  • Create a recovery function which is triggered upon certain scenarios to restart ADCs force sleep and wake chips, etc.
  • Improve the analyzer layer to use the voltages filled segment.c
  • All of the balancing logic

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)

@jr1221 jr1221 requested a review from Sabramz January 24, 2025 21:29
@jr1221 jr1221 merged commit 3dafe3b into 133-adbms-integration Jan 25, 2025
2 checks passed
@jr1221 jr1221 deleted the adbms-fixups-preempt branch January 25, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant