Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/visuals: update indent-blankline to v3 #154

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Conversation

NotAShelf
Copy link
Owner

@NotAShelf NotAShelf commented Oct 14, 2023

Updates indent-blankline to v3 and removes the workaround requiring vim.wo.colorcolumn = "99999" - reported to be fixed upstream in neovim.

I've renamed some of the module options, and I'd really like to use lib.mkRemovedOptionModule and lib.mkRenamedOptionModule, however, both of those cause the build system to assert the files they are defined in (wherever they are) are not actually modules.

@NotAShelf NotAShelf added this to the 0.5 milestone Oct 23, 2023
@NotAShelf
Copy link
Owner Author

Blocked by #178

@FrothyMarrow
Copy link
Contributor

FrothyMarrow commented Nov 16, 2023

I think scope.enabled might be a better name for scope.showCurrContext and helps users that are translating examples from README.md. For same reasons, description might be better defined as Show current scope of variables and functions with treesitter. Other than that it looks good to me 👍

@NotAShelf NotAShelf merged commit 712b8a8 into main Nov 24, 2023
7 checks passed
@NotAShelf NotAShelf deleted the feat/bump-ibl branch November 24, 2023 16:36
bloxx12 pushed a commit to bloxx12/nvf that referenced this pull request Sep 29, 2024
modules/visuals: update indent-blankline to v3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants