Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] payment_redsys: Migration to 15.0 #2149

Closed
wants to merge 56 commits into from
Closed

[15.0][MIG] payment_redsys: Migration to 15.0 #2149

wants to merge 56 commits into from

Conversation

luisplanes
Copy link

Migración y actualización del módulo a la nueva API de gestión de pagos externos.

@oca-clabot
Copy link

Hey @luisplanes, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@luisplanes
Copy link
Author

Queda pendiente la limpieza del código y agregar casos de test.

@HaraldPanten
Copy link
Contributor

/ocabot migration payment_redsys

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Mar 22, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 22, 2022
48 tasks
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprobación funcional

@HaraldPanten
Copy link
Contributor

@luisplanes ¿Puedes hacer rebase para solventar los conflictos?

Saludos.

@ao-landoo
Copy link
Contributor

@pedrobaeza Los test fallan por lo siguiente:

File "/opt/odoo/addons/account/models/account_journal.py", line 437, in _check_payment_method_line_ids_multiplicity raise ValidationError(_("Some payment methods supposed to be unique already exists somewhere else.\n" odoo.exceptions.ValidationError: Some payment methods supposed to be unique already exists somewhere else. ([redsys] Redsys (inbound))

Parece estar relacionado con el módulo l10n_es_dua_sii por lo que se ve en el traceback, lo que se me hace raro. En cambio, en local los test pasan correctamente.

¿Tienes alguna idea de que puede ser?

@pedrobaeza
Copy link
Member

El error que mencionas no tiene que ver con el DUA, si no con el método de pago que está introduciendo este módulo.

sergio-teruel and others added 19 commits June 24, 2022 09:55
* Corregido error en caso de que refence no este
  informado, al renderizar la plantilla del boton de pago.
* Corregido error que no permite pagar por transferencia al instalar
  el modulo payment_redsys
* Añadidas descripciones de los productos de la cesta a la clave 'DS_Merchant_ProductDescription'.
* Make quotation sending optional
  when a transaction ends without error website_sale module already sends an e-mail with the confirmed order, so it May not be necessary to send another e-mail with the same order unconfirmed.
* Add more Redsys frontend languages
* Remove options tab
* Send quotation e-mail invoking force_quotation_send() instead of action_quotation_send() + send_mail()

  * The function send_mail() does not respect the context language so the email is always sent in English.
  * It's not necessary to create the function send_mail() to sent an email when exists the method force_quotation_send().

* Add detailed error info
…r payment + Default values for urk_KO and url_OK + option to print print sale report. Delete url_ok and url_ko fields + Redondeo de merchant_amount
The discount is shown on the order summary if the current user is a member of sale.group_discount_per_so_line group

OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex
[IMP] payment_redsys: Allow partial payment by percent
Includes to allow show order for unauthenticated users
When we have an order sequence of length six (SO123456), the signature process fails with the following message:

Server Error:
We are not able to redirect you to the payment form. 'str' object has no attribute 'decode'
manuelregidor and others added 16 commits June 24, 2022 09:55
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-14.0/l10n-spain-14.0-payment_redsys
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-payment_redsys/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-14.0/l10n-spain-14.0-payment_redsys
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-payment_redsys/
For a JSON request there's no website attribute. This is the case for
payment links. We try to fallback to context if it has the `website_id`
in it. Otherwise, `web.base.url` will be our last resource as usual.

TT34154
@beyondtechinc
Copy link

Hello guys, any updates about this?

@ao-landoo
Copy link
Contributor

Hello guys, any updates about this?

Hi, reviews are needed

@beyondtechinc
Copy link

Hello guys, any updates about this?

Hi, reviews are needed

Any ways we could help? We are not developers more than an enthusiast, but our website is up and running and we could test in staging or one of our other databases. We are running: Odoo 15.0+e Versión Enterprise

@cramosh

This comment was marked as resolved.

@pedrobaeza
Copy link
Member

Habría que tener en cuenta #2476

@pedrobaeza pedrobaeza changed the title [MIG] payment_redsys: Migration to 15.0 [15.0][MIG] payment_redsys: Migration to 15.0 Sep 3, 2022
@luisplanes
Copy link
Author

luisplanes commented Oct 11, 2022 via email

@chienandalu
Copy link
Member

Hay que tener en cuenta también #2825

@Ranamiu
Copy link

Ranamiu commented Mar 29, 2023

Hi all, hi @luisplanes:

Might you please confirm it is ready for 15 ?

Thank you

Best regards

@pedrobaeza
Copy link
Member

Reemplazada por #2968 con todos los cambios necesarios para hacerlo funcionar y que están en ramas anteriores.

@pedrobaeza pedrobaeza closed this Apr 1, 2023
@Ranamiu
Copy link

Ranamiu commented Apr 3, 2023

Thank you mates @pedrobaeza @sergio-teruel @OCA-git-bot

Will have a try this week.

Appreciate !
BR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.