[15.0] fix permission issues when running as non-admin user

[sbidoul]

Towards #415

[oca-clabot]

Hey @sbidoul, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

• oca-ci [email protected] (no github login found)

Appreciation of efforts,
OCA CLAbot

[sbidoul]

This at least lets non-admin use and display mis reports.

Creating report templates still require admin rights in some circumstances, such as creating queries.
I'm not sure how to solve this since we need to display m2o on model and fields in the UI, and these now require admin rights.

Suggestions welcome.

[pedrobaeza]

IIRC, that is only the advanced template options, isn't it? Why not putting them in separate views protected with the same settings permission and let usual templates to work with the same permission level?

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[sbidoul]

@rafaelbn would you like to test this one on runboat?

[loida-vm]

The users can access to MIS Reporting if they are Billing Administrator, but not system administrator.
LGTM 👍

[ghost]

LGTM!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[rafaelbn]

My review with a question:

• Should have access to MIS REPORT a only "Billing" user?

https://www.loom.com/share/3f7fcc9634bf4d6ebe7b56ef4402a882

[sbidoul]

/ocabot merge patch

Thanks for the review, folks.

@rafaelbn regarding access for billing users, well, it's debatable, but I think it is a reasonable default. It's been like this forever.
After all company P&L and Balance Sheet are typically public information.
And Billing Users have access to account moves anyway, so it's just an URL away from being visible.

We have done projects where access to account move was restricted by department and such so department managers can see the P&L of their department but not others.

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-416-by-sbidoul-bump-patch, awaiting test results.

[pedrobaeza]

The menu visibility was modified in #460

[OCA-git-bot]

Congratulations, your PR was merged at 331504a. Thanks a lot for contributing to OCA. ❤️