[15.0][IMP] base_report_to_printer: exceptions notifications #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better handling of exceptions feedback. A notification will show up with the issued printer and report and a button for the user to download the report as a fallback to the failure. TT51628
chienandalu
commented
Nov 11, 2024
| @@ -657,7 +666,7 @@ msgstr "Lista de impresoras" | |||
| #: model:ir.ui.menu,name:base_report_to_printer.printing_menu | |||
| #: model_terms:ir.ui.view,arch_db:base_report_to_printer.view_users_form | |||
| msgid "Printing" | |||
| msgstr "Impresión" | |||
| msgstr "Imprimiendo" | |||
There was a problem hiding this comment.
Looks like my system is introducing bad translations... :/
carlosdauden
approved these changes
Nov 11, 2024
sergio-teruel
approved these changes
Nov 11, 2024
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 292d876. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better handling of exceptions feedback. A notification will show up with the issued printer and report and a button for the user to download the report as a fallback to the failure.
cc @Tecnativa TT51628
please review @sergio-teruel @carlosdauden