Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] base_report_to_printer: exceptions notifications #378

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions base_report_to_printer/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,13 @@ Guidelines for use:
When no tray is configured for a report and a user, the
default tray setup on the CUPS server is used.

Known issues / Roadmap
======================

- With threaded printing there's no download fallback when the issue isn't detected by
the CUPS Odoo backend. To able to do it, we would need to notify the bus or use
web_notify for it.

Changelog
=========

Expand Down
21 changes: 20 additions & 1 deletion base_report_to_printer/i18n/base_report_to_printer.pot
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ msgid ""
msgstr ""
"Project-Id-Version: Odoo Server 15.0\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2024-11-11 16:21+0000\n"
"PO-Revision-Date: 2024-11-11 16:21+0000\n"
"Last-Translator: \n"
"Language-Team: \n"
"MIME-Version: 1.0\n"
Expand Down Expand Up @@ -379,6 +381,13 @@ msgstr ""
msgid "If checked, this server is useable."
msgstr ""

#. module: base_report_to_printer
#. openerp-web
#: code:addons/base_report_to_printer/static/src/js/qweb_action_manager.esm.js:0
#, python-format
msgid "Issue on"
msgstr ""

#. module: base_report_to_printer
#: model_terms:ir.ui.view,arch_db:base_report_to_printer.printing_job_view_form
msgid "Job"
Expand Down Expand Up @@ -552,8 +561,11 @@ msgid "Port of the server."
msgstr ""

#. module: base_report_to_printer
#. openerp-web
#: code:addons/base_report_to_printer/static/src/js/qweb_action_manager.esm.js:0
#: model_terms:ir.ui.view,arch_db:base_report_to_printer.act_report_xml_view
#: model_terms:ir.ui.view,arch_db:base_report_to_printer.wizard_print_attachment_form
#, python-format
msgid "Print"
msgstr ""

Expand Down Expand Up @@ -828,7 +840,7 @@ msgstr ""
#. openerp-web
#: code:addons/base_report_to_printer/static/src/js/qweb_action_manager.esm.js:0
#, python-format
msgid "The printer couldn't be reached. Downloading document instead"
msgid "The report"
msgstr ""

#. module: base_report_to_printer
Expand Down Expand Up @@ -950,6 +962,13 @@ msgstr ""
msgid "Wizard"
msgstr ""

#. module: base_report_to_printer
#. openerp-web
#: code:addons/base_report_to_printer/static/src/js/qweb_action_manager.esm.js:0
#, python-format
msgid "couldn't be printed. Click on the button below to download it"
msgstr ""

#. module: base_report_to_printer
#: code:addons/base_report_to_printer/wizards/print_attachment_report.py:0
#, python-format
Expand Down
94 changes: 41 additions & 53 deletions base_report_to_printer/i18n/es.po
Original file line number Diff line number Diff line change
@@ -1,23 +1,21 @@
# Translation of Odoo Server.
# This file contains the translation of the following modules:
# * base_report_to_printer
# * base_report_to_printer
#
# Translators:
# OCA Transbot <[email protected]>, 2017
msgid ""
msgstr ""
"Project-Id-Version: Odoo Server 11.0\n"
"Project-Id-Version: Odoo Server 15.0\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-12-19 03:38+0000\n"
"PO-Revision-Date: 2023-10-16 19:36+0000\n"
"Last-Translator: Ivorra78 <[email protected]>\n"
"Language-Team: Spanish (https://www.transifex.com/oca/teams/23907/es/)\n"
"POT-Creation-Date: 2024-11-11 16:26+0000\n"
"PO-Revision-Date: 2024-11-11 17:27+0100\n"
"Last-Translator: \n"
"Language-Team: \n"
"Language: es\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: \n"
"Plural-Forms: nplurals=2; plural=n != 1;\n"
"X-Generator: Weblate 4.17\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=2; plural=(n != 1);\n"
"X-Generator: Poedit 3.4.4\n"

#. module: base_report_to_printer
#: model:ir.model.fields.selection,name:base_report_to_printer.selection__printing_job__job_state__aborted
Expand Down Expand Up @@ -59,7 +57,8 @@ msgstr "Archivado"
#. module: base_report_to_printer
#: model_terms:ir.ui.view,arch_db:base_report_to_printer.printing_printer_view_form
msgid "Are you sure to want to cancel all jobs of this printer?"
msgstr "¿Estás seguro que quieres cancelar todos los trabajos de la impresora?"
msgstr ""
"¿Estás seguro que quieres cancelar todos los trabajos de la impresora?"

#. module: base_report_to_printer
#: model_terms:ir.ui.view,arch_db:base_report_to_printer.printing_printer_view_form
Expand Down Expand Up @@ -298,7 +297,7 @@ msgstr "Política de cifrado para conectar al servidor. Vacía por defecto."
#. module: base_report_to_printer
#: model:ir.model.fields.selection,name:base_report_to_printer.selection__printing_printer__status__error
msgid "Error"
msgstr "Error"
msgstr ""

#. module: base_report_to_printer
#: model:ir.model.fields.selection,name:base_report_to_printer.selection__printing_job__job_state_reason__compression-error
Expand All @@ -314,8 +313,8 @@ msgstr "Error en el documento"
#: code:addons/base_report_to_printer/models/printing_server.py:0
#, python-format
msgid ""
"Failed to connect to the CUPS server on %(address)s:%(port)s. Check that the "
"CUPS server is running and that you can reach it from the Odoo server."
"Failed to connect to the CUPS server on %(address)s:%(port)s. Check that "
"the CUPS server is running and that you can reach it from the Odoo server."
msgstr ""
"Ha fallado la conexión al servidor CUPS en %(address)s:%(port)s. Compruebe "
"que el servidor CUPS está en funcionamiento y que el servidor de Odoo tiene "
Expand Down Expand Up @@ -379,7 +378,7 @@ msgstr "Retenido por que la impresora está desconectada"
#: model:ir.model.fields,field_description:base_report_to_printer.field_wizard_print_attachment__id
#: model:ir.model.fields,field_description:base_report_to_printer.field_wizard_print_attachment_line__id
msgid "ID"
msgstr "ID"
msgstr ""

#. module: base_report_to_printer
#: model:ir.model.fields,help:base_report_to_printer.field_printing_server__address
Expand All @@ -391,6 +390,13 @@ msgstr "Dirección IP o nombre del servidor"
msgid "If checked, this server is useable."
msgstr "Si está marcado, el servidor es utilizable."

#. module: base_report_to_printer
#. openerp-web
#: code:addons/base_report_to_printer/static/src/js/qweb_action_manager.esm.js:0
#, python-format
msgid "Issue on"
msgstr "Incidencia en"

#. module: base_report_to_printer
#: model_terms:ir.ui.view,arch_db:base_report_to_printer.printing_job_view_form
msgid "Job"
Expand Down Expand Up @@ -480,7 +486,7 @@ msgstr "Modelo"
#: model:ir.model.fields,field_description:base_report_to_printer.field_printing_printer__multi_thread
#: model:ir.model.fields,field_description:base_report_to_printer.field_printing_server__multi_thread
msgid "Multi Thread"
msgstr ""
msgstr "Multi Hilo"

#. module: base_report_to_printer
#: model:ir.model.fields,field_description:base_report_to_printer.field_printing_action__name
Expand Down Expand Up @@ -515,7 +521,7 @@ msgstr "Sin razón"
#. module: base_report_to_printer
#: model_terms:ir.ui.view,arch_db:base_report_to_printer.printer_update_wizard
msgid "Ok"
msgstr "Ok"
msgstr ""

#. module: base_report_to_printer
#: model:ir.model.fields,field_description:base_report_to_printer.field_ir_actions_report__printer_tray_id
Expand Down Expand Up @@ -564,8 +570,11 @@ msgid "Port of the server."
msgstr "Puerto del servidor."

#. module: base_report_to_printer
#. openerp-web
#: code:addons/base_report_to_printer/static/src/js/qweb_action_manager.esm.js:0
#: model_terms:ir.ui.view,arch_db:base_report_to_printer.act_report_xml_view
#: model_terms:ir.ui.view,arch_db:base_report_to_printer.wizard_print_attachment_form
#, python-format
msgid "Print"
msgstr "Imprimir"

Expand Down Expand Up @@ -657,7 +666,7 @@ msgstr "Lista de impresoras"
#: model:ir.ui.menu,name:base_report_to_printer.printing_menu
#: model_terms:ir.ui.view,arch_db:base_report_to_printer.view_users_form
msgid "Printing"
msgstr "Impresión"
msgstr "Imprimiendo"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like my system is introducing bad translations... :/


#. module: base_report_to_printer
#: model:res.groups,name:base_report_to_printer.printing_group_manager
Expand Down Expand Up @@ -727,7 +736,7 @@ msgstr "Informe"
#. module: base_report_to_printer
#: model:ir.model,name:base_report_to_printer.model_ir_actions_report
msgid "Report Action"
msgstr "Informar Acción"
msgstr "Acción de informe"

#. module: base_report_to_printer
#: model_terms:ir.ui.view,arch_db:base_report_to_printer.printing_report_xml_action_view_form
Expand Down Expand Up @@ -840,8 +849,8 @@ msgstr "El ID del trabajo debe ser único por servidor !"
#. openerp-web
#: code:addons/base_report_to_printer/static/src/js/qweb_action_manager.esm.js:0
#, python-format
msgid "The printer couldn't be reached. Downloading document instead"
msgstr ""
msgid "The report"
msgstr "El informe"

#. module: base_report_to_printer
#: model:ir.model.fields,help:base_report_to_printer.field_ir_actions_report__printing_action_ids
Expand All @@ -851,7 +860,8 @@ msgstr "Este campo permite configurar acción e impresora a nivel de usuario"
#. module: base_report_to_printer
#: model_terms:ir.ui.view,arch_db:base_report_to_printer.printer_update_wizard
msgid ""
"This process will create all missing printers from the current CUPS server.\""
"This process will create all missing printers from the current CUPS server."
"\""
msgstr ""
"Este proceso creará todas las impresoras que falten desde el servidor CUPS "
"actual"
Expand Down Expand Up @@ -890,7 +900,7 @@ msgstr "Tipo"
#. module: base_report_to_printer
#: model:ir.model.fields,field_description:base_report_to_printer.field_printing_printer__uri
msgid "URI"
msgstr "URI"
msgstr ""

#. module: base_report_to_printer
#: model:ir.model.fields.selection,name:base_report_to_printer.selection__printing_printer__status__unavailable
Expand Down Expand Up @@ -963,37 +973,15 @@ msgstr "Usuarios"
msgid "Wizard"
msgstr "Asistente"

#. module: base_report_to_printer
#. openerp-web
#: code:addons/base_report_to_printer/static/src/js/qweb_action_manager.esm.js:0
#, python-format
msgid "couldn't be printed. Click on the button below to download it"
msgstr "no se ha podido imprimir. Pulsar en el botón para descargarlo"

#. module: base_report_to_printer
#: code:addons/base_report_to_printer/wizards/print_attachment_report.py:0
#, python-format
msgid "{name} ({copies} copies)"
msgstr "{name} ({copies} copies) :{name} ({copies} copias)"

#, python-format
#~ msgid "Document sent to the printer %s"
#~ msgstr "Documento enviado a la impresora %s"

#, python-format
#~ msgid "Error when sending the document to the printer "
#~ msgstr "Error enviando el documento a la impresora "

#, python-format
#~ msgid ""
#~ "Failed to connect to the CUPS server on %s:%s. Check that the CUPS server "
#~ "is running and that you can reach it from the Odoo server."
#~ msgstr ""
#~ "Ha fallado la conexión al servidor CUPS %s:%s. Comprueba que el servidor "
#~ "CUPS está funcionando y que el servidor de Odoo puede comunicarse con él."

#~ msgid ""
#~ "This process will create all missing printers from the current CUPS "
#~ "server."
#~ msgstr ""
#~ "Este proceso creará las impresoras no configurada del servidor CUPS "
#~ "actual."

#~ msgid "or"
#~ msgstr "o"

#~ msgid "ir.actions.report"
#~ msgstr "ir.actions.report"
8 changes: 7 additions & 1 deletion base_report_to_printer/models/ir_actions_report.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@
"skip_printer_exception"
):
serializable_result["printer_exception"] = True
if self.env.context.get("force_print_to_client"):
serializable_result["action"] = "client"

Check warning on line 63 in base_report_to_printer/models/ir_actions_report.py

View check run for this annotation

Codecov / codecov/patch

base_report_to_printer/models/ir_actions_report.py#L63

Added line #L63 was not covered by tests
return serializable_result

def _get_user_default_print_behaviour(self):
Expand Down Expand Up @@ -135,7 +137,10 @@

return True
else:
return self.print_document(record_ids, data=data)
try:
return self.print_document(record_ids, data=data)
except Exception:
return

Check warning on line 143 in base_report_to_printer/models/ir_actions_report.py

View check run for this annotation

Codecov / codecov/patch

base_report_to_printer/models/ir_actions_report.py#L140-L143

Added lines #L140 - L143 were not covered by tests

def print_document_threaded(self, report_id, record_ids, data):
with registry(self._cr.dbname).cursor() as cr:
Expand Down Expand Up @@ -171,6 +176,7 @@
else:
title = self.report_name
behaviour["title"] = title
behaviour["res_ids"] = record_ids
# TODO should we use doc_format instead of report_type
return printer.print_document(
self, document, doc_format=self.report_type, **behaviour
Expand Down
3 changes: 3 additions & 0 deletions base_report_to_printer/readme/ROADMAP.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- With threaded printing there's no download fallback when the issue isn't detected by
the CUPS Odoo backend. To able to do it, we would need to notify the bus or use
web_notify for it.
Loading
Loading