Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloud data source config): GUI and API for configuring a cloud data source with Google cloud healthcare implementation #3589

Merged
merged 6 commits into from
Aug 25, 2023

Conversation

jbocce
Copy link
Collaborator

@jbocce jbocce commented Aug 9, 2023

Context

OHIF requires a GUI interface to configure a cloud server API data source such as...

  • Google cloud healthcare
  • AWS health imaging
  • Azure

This is a PR for configuring a Google dicom web data source.

Changes & Results

Introduced generic interfaces (i.e. BaseDataSourceConfigurationAPI, BaseDataSourceConfigurationAPIItem)
to facilitate the configuration of an arbitrary data source - in particular
a cloud data source such as Google.

Implemented a generic GUI that uses the generic interfaces to allow users to configure a data source
via a GUI.

Implemented concrete implementations of the interfaces for Google.

Introduced the InputFilterText GUI component to handle the input of filtering text.

Testing

  1. Checkout the jbocce:feat/cloud-server-api-gui-picker branch.
  2. Set the APP_CONFIG environment variable to 'config/google.js'.
  3. yarn install
  4. yarn start
  5. Click on the Google data source summary and/or gear icon next to the Study List label.
  6. Configure various Google dicom stores. Those most useful are under: OHIF Cloud Healthcare - us-east4 and OHIF Cloud Healthcare - us-central1.

The various GUI components, modals, panels, etc. should closely approximate what was provided by @dan-rukas below. Thanks Dan!

image

image

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 16.14.0
  • Browser: Chrome 115.0.5790.171

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 3be8e30
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64e8ce55bc4947000808d267

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 3be8e30
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64e8ce55e91af200080c3e39
😎 Deploy Preview https://deploy-preview-3589--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #3589 (3be8e30) into master (65b49ae) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3589   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files          80       80           
  Lines        1463     1463           
  Branches      340      340           
=======================================
  Hits          623      623           
  Misses        675      675           
  Partials      165      165           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2ef2b0...3be8e30. Read the comment docs.

@jbocce jbocce force-pushed the feat/cloud-server-api-gui-picker branch from 8691476 to 990d03c Compare August 9, 2023 18:57
@jbocce jbocce requested a review from sedghi August 9, 2023 19:03
Introduced generic interfaces (i.e. BaseDataSourceConfigurationAPI, BaseDataSourceConfigurationAPIItem)
to facilitate the configuration of an arbitrary data source - in particular
a cloud data source such as Google.

Implemented a generic GUI that uses the generic interfaces to allow users to configure a data source
via a GUI.

Implemented concrete implementations of the interfaces for Google.

Introduced the InputFilterText GUI component to handle the input of filtering text.
@jbocce jbocce force-pushed the feat/cloud-server-api-gui-picker branch 2 times, most recently from 8723f94 to 88aed48 Compare August 22, 2023 16:14
@jbocce jbocce changed the title DRAFT: cloud server API generic interface to configure a data source - rough Google implementation feat(cloud data source config): GUI and API for configuring a cloud data source with Google cloud healthcare implementation Aug 22, 2023
@jbocce jbocce marked this pull request as ready for review August 22, 2023 16:25
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments, great work so far

jbocce added 4 commits August 25, 2023 07:43
…mponents.

Now showing the data source's current/full configuration when the configuration component first opens.
Added InputFilterText Storybook story.
@jbocce jbocce requested a review from sedghi August 25, 2023 12:41
@jbocce
Copy link
Collaborator Author

jbocce commented Aug 25, 2023

@sedghi, there is one e2e test failing (namely OHIFVideoDisplay.spec.js), but try locally and it is fine. Not sure how to proceed. Thanks.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just minor comment. I tried it and worked fine. Great job

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@sedghi sedghi merged commit a336992 into OHIF:master Aug 25, 2023
@jbocce jbocce deleted the feat/cloud-server-api-gui-picker branch August 28, 2023 00:01
Sofien-Sellami pushed a commit to Sofien-Sellami/Viewers that referenced this pull request Oct 5, 2023
…ata source with Google cloud healthcare implementation (OHIF#3589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants