-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloud data source config): GUI and API for configuring a cloud data source with Google cloud healthcare implementation #3589
Conversation
✅ Deploy Preview for ohif-dev canceled.
|
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3589 +/- ##
=======================================
Coverage 42.58% 42.58%
=======================================
Files 80 80
Lines 1463 1463
Branches 340 340
=======================================
Hits 623 623
Misses 675 675
Partials 165 165 Continue to review full report in Codecov by Sentry.
|
8691476
to
990d03c
Compare
extensions/default/src/CloudServerAPI/GoogleCloudServerAPI/GoogleCloudServerAPI.ts
Outdated
Show resolved
Hide resolved
extensions/default/src/CloudServerAPI/GoogleCloudServerAPI/GoogleCloudServerAPI.ts
Outdated
Show resolved
Hide resolved
extensions/default/src/Components/CloudServerConfigurationComponent.tsx
Outdated
Show resolved
Hide resolved
extensions/default/src/Components/CloudServerConfigurationComponent.tsx
Outdated
Show resolved
Hide resolved
Introduced generic interfaces (i.e. BaseDataSourceConfigurationAPI, BaseDataSourceConfigurationAPIItem) to facilitate the configuration of an arbitrary data source - in particular a cloud data source such as Google. Implemented a generic GUI that uses the generic interfaces to allow users to configure a data source via a GUI. Implemented concrete implementations of the interfaces for Google. Introduced the InputFilterText GUI component to handle the input of filtering text.
8723f94
to
88aed48
Compare
extensions/default/src/DataSourceConfigurationAPI/GoogleCloudDataSourceConfigurationAPI.ts
Show resolved
Hide resolved
extensions/default/src/DataSourceConfigurationAPI/GoogleCloudDataSourceConfigurationAPI.ts
Outdated
Show resolved
Hide resolved
extensions/default/src/DataSourceConfigurationAPI/GoogleCloudDataSourceConfigurationAPI.ts
Show resolved
Hide resolved
extensions/default/src/Components/DataSourceConfigurationComponent.tsx
Outdated
Show resolved
Hide resolved
extensions/default/src/Components/DataSourceConfigurationComponent.tsx
Outdated
Show resolved
Hide resolved
extensions/default/src/Components/DataSourceConfigurationComponent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments, great work so far
…mponents. Now showing the data source's current/full configuration when the configuration component first opens.
Added InputFilterText Storybook story.
@sedghi, there is one e2e test failing (namely OHIFVideoDisplay.spec.js), but try locally and it is fine. Not sure how to proceed. Thanks. |
extensions/default/src/Components/DataSourceConfigurationComponent.tsx
Outdated
Show resolved
Hide resolved
extensions/default/src/Components/DataSourceConfigurationModalComponent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just minor comment. I tried it and worked fine. Great job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!
…ata source with Google cloud healthcare implementation (OHIF#3589)
Context
OHIF requires a GUI interface to configure a cloud server API data source such as...
This is a PR for configuring a Google dicom web data source.
Changes & Results
Introduced generic interfaces (i.e. BaseDataSourceConfigurationAPI, BaseDataSourceConfigurationAPIItem)
to facilitate the configuration of an arbitrary data source - in particular
a cloud data source such as Google.
Implemented a generic GUI that uses the generic interfaces to allow users to configure a data source
via a GUI.
Implemented concrete implementations of the interfaces for Google.
Introduced the InputFilterText GUI component to handle the input of filtering text.
Testing
jbocce:feat/cloud-server-api-gui-picker
branch.'config/google.js'
.yarn install
yarn start
Study List
label.OHIF Cloud Healthcare - us-east4
andOHIF Cloud Healthcare - us-central1
.The various GUI components, modals, panels, etc. should closely approximate what was provided by @dan-rukas below. Thanks Dan!
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment