Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua file handler #332

Closed
wants to merge 2 commits into from
Closed

Lua file handler #332

wants to merge 2 commits into from

Conversation

naivling
Copy link

Make sure these boxes are signed before submitting your Pull Request
-- thank you.

Link to redmine ticket:https://redmine.openinfosecfoundation.org/issues/6395

Describe changes:
I added the function handle_lua_rule_files, which obviously handles lua files shipped within a rule tarball.
It works nearly exactly the same as the existing functions handle_filehash_files and handle_dataset_files.
testing was done for nested and non nested archives, and for single and multiple occurances of lua and luajit keywords in rules.
It assumes the final outputdir is called "rules", but handle_filehash_files does the same, so this wont break setups not already broken.

@naivling naivling requested a review from jasonish as a code owner October 16, 2023 09:08
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @naivling !
Thank you for your first contribution to our project. :)
Could you please

  1. Squash the commits
  2. Make the commit message like other commits in the repo
  3. Add ticket number to the commit
  4. Assign ticket to yourself on redmine

@naivling
Copy link
Author

Hi @inashivb
1 and 2 are done,
but I don't get, what you meant with

3. Add ticket number to the commit

Should I include it in the commit-message, or am I supposed to really commit the ticket number in some way?

Sorry for the trouble, its my first PR in any project.

@inashivb
Copy link
Member

Hi @inashivb 1 and 2 are done, but I don't get, what you meant with

3. Add ticket number to the commit

Should I include it in the commit-message, or am I supposed to really commit the ticket number in some way?

Yes, please. In the commit message. Example: 9304746

Sorry for the trouble, its my first PR in any project.

No problem. :)

@naivling
Copy link
Author

After applying the requested changes to a new branch, this PR is now superseded by a new one

@naivling naivling closed this Oct 18, 2023
@naivling naivling deleted the lua_file_handler branch October 18, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants