Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua:handle lua detection scripts from archives V2 #333

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naivling
Copy link

look for "lua" and "luajit" keywords in rules and store the referenced file if found in the fetched archive, just like done with datasets and filehashes.
Ticket: #6395

Make sure these boxes are signed before submitting your Pull Request
-- thank you.

Link to redmine ticket:https://redmine.openinfosecfoundation.org/issues/6395?issue_count=37&issue_position=1&next_issue_id=6298

Describe changes:

  • added the function handle_lua_rule_files
    • structure and usage is just like handle_filehash_files
  • added the calling logic for the function
    • again just like already done with filehash files
  • changes compared to last PR
    • squashed commits
    • commit message now fits better into past commit messages and includes ticket number
    • ticket is assigned to the author

look for "lua" and "luajit" keywords in rules and store the referenced
file if found in the fetched archive, just like done with datasets and
filehashes.
Ticket: #6395
@naivling naivling requested a review from jasonish as a code owner October 17, 2023 12:06
@naivling naivling changed the title lua:handle lua detection scripts from archives lua:handle lua detection scripts from archives V2 Oct 17, 2023
@naivling naivling closed this Oct 17, 2023
@naivling naivling reopened this Oct 17, 2023
@naivling naivling mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant