Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow waiting for a minimum amount of time since parent assertion was created to post a new assertion #2825

Merged
merged 10 commits into from
Jan 6, 2025

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Dec 9, 2024

This PR allows to set a duration for assertions manager to wait to since the parent assertion was created before posting a new assertion. Configurable via the config option --node.bold.minimum-gap-to-parent-assertion

Pulls in bold PR- OffchainLabs/bold#714
Resolves NIT-2961

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Dec 9, 2024
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review December 9, 2024 22:36
PlasmaPower
PlasmaPower previously approved these changes Dec 17, 2024
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljobe eljobe self-requested a review January 3, 2025 12:27
eljobe
eljobe previously approved these changes Jan 3, 2025
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganeshvanahalli ganeshvanahalli dismissed stale reviews from eljobe and PlasmaPower via 830a924 January 3, 2025 16:00
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 41ad6fa into master Jan 6, 2025
15 of 16 checks passed
@PlasmaPower PlasmaPower deleted the minimum-gapto-parentassertion branch January 6, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants