Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow waiting for a minimum amount of time since parent assertion was created to post a new assertion #2825

Merged
merged 10 commits into from
Jan 6, 2025
Merged

Allow waiting for a minimum amount of time since parent assertion was created to post a new assertion #2825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5eb9704
Allow waiting for a minimum amount of time since parent assertion was…
ganeshvanahalli Dec 9, 2024
81dcb5a
minor fix
ganeshvanahalli Dec 9, 2024
4859179
Merge branch 'master' into minimum-gapto-parentassertion
ganeshvanahalli Dec 10, 2024
231da30
update bold pin
ganeshvanahalli Dec 10, 2024
3ada786
Merge branch 'master' into minimum-gapto-parentassertion
PlasmaPower Dec 17, 2024
ad9ed98
Merge branch 'master' into minimum-gapto-parentassertion
tsahee Dec 27, 2024
f2aebf6
Merge branch 'master' into minimum-gapto-parentassertion
joshuacolvin0 Dec 30, 2024
820df1e
Merge branch 'master' into minimum-gapto-parentassertion
tsahee Jan 3, 2025
d72b1af
Merge branch 'master' into minimum-gapto-parentassertion
tsahee Jan 3, 2025
830a924
update bold pin to latest commit on main
ganeshvanahalli Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions arbnode/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ func ConfigDefaultL1NonSequencerTest() *Config {
config.Staker = legacystaker.TestL1ValidatorConfig
config.Staker.Enable = false
config.BlockValidator.ValidationServerConfigs = []rpcclient.ClientConfig{{URL: ""}}
config.Bold.MinimumGapToParentAssertion = 0

return &config
}
Expand All @@ -230,6 +231,7 @@ func ConfigDefaultL2Test() *Config {
config.Staker.Enable = false
config.BlockValidator.ValidationServerConfigs = []rpcclient.ClientConfig{{URL: ""}}
config.TransactionStreamer = DefaultTransactionStreamerConfig
config.Bold.MinimumGapToParentAssertion = 0

return &config
}
Expand Down
2 changes: 1 addition & 1 deletion bold
Open in desktop
Submodule bold updated 25 files
+6 −6 README.md
+7 −69 api/backend/backend.go
+19 −30 api/server/methods.go
+3 −2 assertions/confirmation.go
+98 −8 assertions/manager.go
+6 −0 assertions/manager_test.go
+47 −30 assertions/poster.go
+4 −0 assertions/poster_test.go
+9 −5 assertions/sync.go
+18 −10 chain-abstraction/interfaces.go
+2 −0 chain-abstraction/sol-implementation/BUILD.bazel
+182 −6 chain-abstraction/sol-implementation/assertion_chain.go
+25 −0 chain-abstraction/sol-implementation/assertion_chain_test.go
+16 −15 chain-abstraction/sol-implementation/edge_challenge_manager.go
+10 −2 chain-abstraction/sol-implementation/transact.go
+12 −12 chain-abstraction/sol-implementation/types.go
+3 −3 challenge-manager/chain-watcher/watcher.go
+0 −5 challenge-manager/challenge-tree/mock/edge.go
+13 −3 challenge-manager/edge-tracker/challenge_confirmation.go
+52 −0 challenge-manager/stack.go
+2 −1 testing/endtoend/e2e_crash_test.go
+1 −0 testing/endtoend/e2e_test.go
+1 −0 testing/mocks/BUILD.bazel
+25 −7 testing/mocks/mocks.go
+1 −1 testing/mocks/state-provider/layer2_state_provider.go
7 changes: 6 additions & 1 deletion staker/bold/bold_staker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ type BoldConfig struct {
// How often to scan for newly created assertions onchain.
AssertionScanningInterval time.Duration `koanf:"assertion-scanning-interval"`
// How often to confirm assertions onchain.
AssertionConfirmingInterval time.Duration `koanf:"assertion-confirming-interval"`
AssertionConfirmingInterval time.Duration `koanf:"assertion-confirming-interval"`
// How long to wait since parent assertion was created to post a new assertion
MinimumGapToParentAssertion time.Duration `koanf:"minimum-gap-to-parent-assertion"`
API bool `koanf:"api"`
APIHost string `koanf:"api-host"`
APIPort uint16 `koanf:"api-port"`
Expand Down Expand Up @@ -98,6 +100,7 @@ var DefaultBoldConfig = BoldConfig{
AssertionPostingInterval: time.Minute * 15,
AssertionScanningInterval: time.Minute,
AssertionConfirmingInterval: time.Minute,
MinimumGapToParentAssertion: time.Minute, // Correct default?
API: false,
APIHost: "127.0.0.1",
APIPort: 9393,
Expand All @@ -121,6 +124,7 @@ func BoldConfigAddOptions(prefix string, f *flag.FlagSet) {
f.Duration(prefix+".assertion-posting-interval", DefaultBoldConfig.AssertionPostingInterval, "assertion posting interval")
f.Duration(prefix+".assertion-scanning-interval", DefaultBoldConfig.AssertionScanningInterval, "scan assertion interval")
f.Duration(prefix+".assertion-confirming-interval", DefaultBoldConfig.AssertionConfirmingInterval, "confirm assertion interval")
f.Duration(prefix+".minimum-gap-to-parent-assertion", DefaultBoldConfig.MinimumGapToParentAssertion, "minimum duration to wait since the parent assertion was created to post a new assertion")
f.Duration(prefix+".check-staker-switch-interval", DefaultBoldConfig.CheckStakerSwitchInterval, "how often to check if staker can switch to bold")
f.Bool(prefix+".api", DefaultBoldConfig.API, "enable api")
f.String(prefix+".api-host", DefaultBoldConfig.APIHost, "bold api host")
Expand Down Expand Up @@ -455,6 +459,7 @@ func newBOLDChallengeManager(
challengemanager.StackWithPollingInterval(scanningInterval),
challengemanager.StackWithPostingInterval(postingInterval),
challengemanager.StackWithConfirmationInterval(confirmingInterval),
challengemanager.StackWithMinimumGapToParentAssertion(config.MinimumGapToParentAssertion),
challengemanager.StackWithTrackChallengeParentAssertionHashes(config.TrackChallengeParentAssertionHashes),
challengemanager.StackWithHeaderProvider(l1Reader),
}
Expand Down
1 change: 1 addition & 0 deletions system_tests/bold_challenge_protocol_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,7 @@ func testChallengeProtocolBOLD(t *testing.T, spawnerOpts ...server_arb.SpawnerOp
challengemanager.StackWithMode(modes.MakeMode),
challengemanager.StackWithPostingInterval(time.Second * 3),
challengemanager.StackWithPollingInterval(time.Second),
challengemanager.StackWithMinimumGapToParentAssertion(0),
challengemanager.StackWithAverageBlockCreationTime(time.Second),
}

Expand Down
1 change: 1 addition & 0 deletions system_tests/bold_new_challenge_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,7 @@ func startBoldChallengeManager(t *testing.T, ctx context.Context, builder *NodeB
challengemanager.StackWithPostingInterval(time.Second * 3),
challengemanager.StackWithPollingInterval(time.Second),
challengemanager.StackWithAverageBlockCreationTime(time.Second),
challengemanager.StackWithMinimumGapToParentAssertion(0),
}

challengeManager, err := challengemanager.NewChallengeStack(
Expand Down
1 change: 1 addition & 0 deletions system_tests/overflow_assertions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ func TestOverflowAssertions(t *testing.T) {
challengemanager.StackWithPostingInterval(time.Second),
challengemanager.StackWithPollingInterval(time.Millisecond * 500),
challengemanager.StackWithAverageBlockCreationTime(time.Second),
challengemanager.StackWithMinimumGapToParentAssertion(0),
}

manager, err := challengemanager.NewChallengeStack(
Expand Down
Loading