update to miniforge3 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joernu76 that works locally, can you have a check please |
matrss
reviewed
Jan 22, 2024
Dockerfile
Outdated
| @@ -31,22 +31,22 @@ RUN export DEBIAN_FRONTEND=noninteractive \ | |||
| ENV PYTHONPATH="/srv/mss:/root/mss" | |||
|
|
|||
| # Install requirements, fetched from the specified branch | |||
| RUN wget -O /meta.yaml -q https://raw.githubusercontent.com/Open-MSS/MSS/${BRANCH}/localbuild/meta.yaml \ | |||
| RUN wget -O /meta.yaml -q https://raw.githubusercontent.com/Open-MSS/MSS/${BRANCH}/localbuild/meta.yaml \ | |||
There was a problem hiding this comment.
Does this change have a reason or was it by mistake?
joernu76
reviewed
Jan 30, 2024
|
|
||
| # execute /etc/profile also in non-interactive use | ||
| ENV BASH_ENV /etc/profile.d/conda.sh | ||
| ENV BASH_ENV /etc/profile.d/mamba.sh |
There was a problem hiding this comment.
when I install miniforge, I have to execute conda.sh and mamba.sh for everything to work...
There was a problem hiding this comment.
@joernu76 I tried locally with BRANCH set to develop and
docker run -it $(docker build -q .)
(base) root@e03e9a3fcf42:/# mamba activate mss-develop-env
Which failure have you seen?
There was a problem hiding this comment.
I had issues with an older version of the software. This was just a caveat. I approved the MR:
joernu76
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14