Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to miniforge3 #16

Merged
merged 6 commits into from
Jan 30, 2024
Merged

update to miniforge3 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7081573
update to miniforge
ReimarBauer Jan 22, 2024
7364c83
typo
ReimarBauer Jan 22, 2024
4358202
clean also needs a yes
ReimarBauer Jan 22, 2024
83d5dc0
further updates to mamba
ReimarBauer Jan 22, 2024
318a47d
v4
ReimarBauer Jan 22, 2024
1943768
blank removed
ReimarBauer Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Build image
run: |
Expand Down
10 changes: 5 additions & 5 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Set the base image ubuntu with mamba
FROM condaforge/mambaforge
FROM condaforge/miniforge3

# Sets which branch to fetch requirements from
ARG BRANCH
Expand Down Expand Up @@ -39,14 +39,14 @@ RUN wget -O /meta.yaml -q https://raw.githubusercontent.com/Open-MSS/MSS/${BRANC
| sed -e "s/menuinst.*//" \
| sed -e "s/.*://" > reqs.txt \
&& cat development.txt >> reqs.txt \
&& echo pyvirtualdisplay >> reqs.txt \
&& mamba create -y -n mss-${BRANCH}-env --file reqs.txt \
&& mamba create -y -n mssenv --file reqs.txt \
&& conda clean --all \
&& mamba clean -y --all \
&& rm reqs.txt \
&& cp /opt/conda/etc/profile.d/conda.sh /etc/profile.d/conda.sh
&& cp /opt/conda/etc/profile.d/conda.sh /etc/profile.d/conda.sh \
&& cp /opt/conda/etc/profile.d/mamba.sh /etc/profile.d/mamba.sh

# execute /etc/profile also in non-interactive use
ENV BASH_ENV /etc/profile.d/conda.sh
ENV BASH_ENV /etc/profile.d/mamba.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I install miniforge, I have to execute conda.sh and mamba.sh for everything to work...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joernu76 I tried locally with BRANCH set to develop and

docker run -it $(docker build -q .)
(base) root@e03e9a3fcf42:/# mamba activate mss-develop-env

Which failure have you seen?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had issues with an older version of the software. This was just a caveat. I approved the MR:

# default command to start when run
CMD [ "/bin/bash", "--login" ]