Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Describe setup of OSI visualizer #63

Open
wants to merge 2 commits into
base: migration
Choose a base branch
from
Open

Describe setup of OSI visualizer #63

wants to merge 2 commits into from

Conversation

max-rosin
Copy link

@max-rosin max-rosin commented Jun 1, 2021 •
edited
Loading

This PR resolves #61.

Check the checklist

  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • New and existing unit tests / github actions pass locally with my changes.

@max-rosin max-rosin added the documentation Everything which impacts the quality of the documentation and guidelines. label Jun 3, 2021
ThomasNaderBMW
ThomasNaderBMW reviewed Jun 7, 2021
View reviewed changes
Copy link
Contributor

@ThomasNaderBMW ThomasNaderBMW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but in general thank you very much for your commit! :)

doc/setup/installing_dependencies.adoc Outdated Show resolved Hide resolved
doc/setup/building_docker.adoc Outdated Show resolved Hide resolved
doc/setup/building_visualizer.adoc Outdated Show resolved Hide resolved
@max-rosin
fix(docs): Fix typos (#61)
68e6a62 
Signed-off-by: Maximilian Rosin <[email protected]>
@max-rosin max-rosin force-pushed the 61_describe_setup_of_osi_visualizer branch from 835fe6e to 68e6a62 Compare June 24, 2021 12:16
@max-rosin max-rosin added the ReadyForCCB Ready for Change Control Board label Jun 24, 2021
@stefancyliax stefancyliax removed the ReadyForCCB Ready for Change Control Board label Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ThomasNaderBMW ThomasNaderBMW ThomasNaderBMW left review comments

@clemenshabedank clemenshabedank Awaiting requested review from clemenshabedank

@HendrikAmelunxen HendrikAmelunxen Awaiting requested review from HendrikAmelunxen

@pmai pmai Awaiting requested review from pmai

@0815-code 0815-code Awaiting requested review from 0815-code

@kmeids kmeids Awaiting requested review from kmeids

Assignees
No one assigned
Labels
documentation Everything which impacts the quality of the documentation and guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-rosin @ThomasNaderBMW @stefancyliax