-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Italian language #695
Conversation
res/openvpn-gui-res-it.rc
Outdated
@@ -411,7 +411,8 @@ Per maggiori dettagli consulta il file log (%ls) ." | |||
IDS_NFO_SERVICE_STOPPED "Servizio OpenVPN arrestato." | |||
IDS_NFO_ACTIVE_CONN_EXIT "Ci sono ancora connessioni attive che verranno chiuse se esci dall'interfaccia di OpenVPN.\ | |||
\n\nSei sicuro di voler uscire?" | |||
IDS_ERR_PARSE_MGMT_OPTION "Impossibile analizzare l'opzione --management in <%ls%ls>." | |||
IDS_ERR_PARSE_MGMT_OPTION "Impossibile analizzare l'opzione --management in <%ls%ls>. \ | |||
L'allegato alla connessione automatica richiede l'opzione --management nel file config." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, was this the same sentence that was used before?
The English text says "Attaching to auto-started connections require --management option in the config file."
There is truly no "allegato" in here, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see in english and in previous italian version was available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Could be ok
"Il collegamento a connessioni avviate automaticamente richiede l'opzione --management nel file di configurazione."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Fixed. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please squash everything in one commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new sentence is not appropriate
Why did you close the PR? You could just squash the two commits and force-push to the same branch. |
@ordex |
that this way you open new and new PRs for the same change and on top of that we lose the history of what was discussed before, because the discussion is in an older PR. While if you keep everything in one PR we can see the previous comments |
The previous comment was go over because I applied the string that we and you are agree. |
@bovirus your behaviour is not what you are expected to do and who pull request are supposed to be used. By working this way you basically annoy everything but not doing things the correct way. E.g. I now get multiple notifcation of new pull request being opened and closed, which is annoying. Just we really would like to work and use Github like everyone else. |
@schwabe |
@ordex already told you. SQUASH the commit and update the EXISTING Pr. NOT opening a NEW Pr. Thanks |
I'm afraid but I'm not able to do it. |
@bovirus I can squash on merge (rebase and merge option in github) if you are okay with it. You have to just reopen the PR. |
@selvanair |
@selvanair
Restore a lienr emoved (but necessary) and presnt in english file).