Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Italian language #695

Closed
wants to merge 2 commits into from
Closed

Update Italian language #695

wants to merge 2 commits into from

Conversation

bovirus
Copy link
Contributor

@bovirus bovirus commented Jul 17, 2024

@selvanair

Restore a lienr emoved (but necessary) and presnt in english file).

@lstipakov lstipakov requested a review from ordex July 17, 2024 09:50
@@ -411,7 +411,8 @@ Per maggiori dettagli consulta il file log (%ls) ."
IDS_NFO_SERVICE_STOPPED "Servizio OpenVPN arrestato."
IDS_NFO_ACTIVE_CONN_EXIT "Ci sono ancora connessioni attive che verranno chiuse se esci dall'interfaccia di OpenVPN.\
\n\nSei sicuro di voler uscire?"
IDS_ERR_PARSE_MGMT_OPTION "Impossibile analizzare l'opzione --management in <%ls%ls>."
IDS_ERR_PARSE_MGMT_OPTION "Impossibile analizzare l'opzione --management in <%ls%ls>. \
L'allegato alla connessione automatica richiede l'opzione --management nel file config."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, was this the same sentence that was used before?
The English text says "Attaching to auto-started connections require --management option in the config file."
There is truly no "allegato" in here, please.

Copy link
Contributor Author

@bovirus bovirus Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in english and in previous italian version was available.

Copy link
Contributor Author

@bovirus bovirus Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Could be ok
"Il collegamento a connessioni avviate automaticamente richiede l'opzione --management nel file di configurazione."?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good! Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Fixed. Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash everything in one commit

Copy link
Member

@ordex ordex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new sentence is not appropriate

@bovirus bovirus closed this Jul 17, 2024
@ordex
Copy link
Member

ordex commented Jul 17, 2024

Why did you close the PR? You could just squash the two commits and force-push to the same branch.
The PR would then be updated accordingly

@bovirus
Copy link
Contributor Author

bovirus commented Jul 17, 2024

@ordex
I prefer to make the changes in one step.
Clear and to avoid mnisudnerstanding.
What's the problem to use this system?

@ordex
Copy link
Member

ordex commented Jul 17, 2024

@ordex I prefer to make the changes in one step. Clear and to avoid mnisudnerstanding. What's the problem to use this system?

that this way you open new and new PRs for the same change and on top of that we lose the history of what was discussed before, because the discussion is in an older PR.

While if you keep everything in one PR we can see the previous comments

@bovirus
Copy link
Contributor Author

bovirus commented Jul 17, 2024

@ordex

The previous comment was go over because I applied the string that we and you are agree.
Sorry but I didn'ts ee the problem.
Thanks.

@schwabe
Copy link

schwabe commented Jul 17, 2024

@bovirus your behaviour is not what you are expected to do and who pull request are supposed to be used. By working this way you basically annoy everything but not doing things the correct way. E.g. I now get multiple notifcation of new pull request being opened and closed, which is annoying. Just we really would like to work and use Github like everyone else.

@bovirus
Copy link
Contributor Author

bovirus commented Jul 17, 2024

@schwabe
Tell me what I should do.
I opened a PR with a change but nothing was ok.

@schwabe
Copy link

schwabe commented Jul 17, 2024

@ordex already told you. SQUASH the commit and update the EXISTING Pr. NOT opening a NEW Pr. Thanks

@bovirus
Copy link
Contributor Author

bovirus commented Jul 17, 2024

@schwabe

I'm afraid but I'm not able to do it.
I don't ahve the right competencies.

@selvanair
Copy link
Collaborator

@bovirus I can squash on merge (rebase and merge option in github) if you are okay with it. You have to just reopen the PR.

@bovirus
Copy link
Contributor Author

bovirus commented Jul 17, 2024

@selvanair
I beleiev that I cannot re-open PR.
To create the new PR I deleted the previous fork.
Pelase tell me how can help you.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants