fix(step-generation): fix blowout location from multi-dispense disposal #17012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds recovery from stall or collision errors to the app. This should implement these flows: https://www.figma.com/design/OGssKRmCOvuXSqUpK2qXrV/Feature%3A-Error-Recovery-November-Release?node-id=9765-66609&t=65NkMVGZlPdCG7z6-4 When there's a stall, which can happen on pretty much any command, we should now prompt the user to home and retry. To home, they have to make sure the machine is safe, so we will go through DTWiz. ## Reviews - [ ] did i miss anything ## Testing - [x] stalls should get you the home and retry button - [x] you should enter the DTWiz if >0 pipettes have a tip - [x] if 0 pipettes have a tip the DTwiz should be skipped (or if there are no pipettes) - [x] Retrying should in fact work Closes EXEC-725
Looks like this is behaving differently on CI than my local docker container tests. Luckily, the error is pretty straightforward: Error: Mixpanel request failed: 401, Unauthorized, Expected project_id parameter to be a number when specified
* refactor(app): clean up react import statements (#16998)
… and definitions (#16972) Adds a correctionByVolume field to liquid class definitions in the schema, pydantic models and PAPI classes for liquid class properties.
Closes AUTH-843 # Overview Adds `InstrumentContext.transfer_liquid()` method that does the following- - validates parameters of `transfer_liquid()` - loads the liquid class properties for the relevant pipette and tiprack into protocol engine - delegates to engine core to perform the actual transfer This PR does not cover engine core's transfer method execution. ## Risk assessment No risk so far since this is a code-only change.
jerader
changed the title
|
having some issues when i changed the target branch - going to open another pr off of the correct branch initially |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RESC-356
Overview
When the blowout Z tip position field for multi dispense diposal was introduced to PD in the 8.1.0 release, we never tested that it actually worked correctly I guess. The bug outlined in the ticket shows that the customer set their blowout tip position to -20mm from the top of the well in multi-dispense diposal but when running their protocol, the blowout still occurred at the top of the well.
The fix was to modify the logic in which the
blowoutOffsetFromTopMmwas set inmoveLiquidFormToArgs. With the blowout Z position field introduced to the multi-dispense disposal section,blowoutLocationwas always being null because it required the user to select the blowout checkbox outside of the disposal section. This PR fixes that by also searching for if the disposal fields and blowout location are filled out.Test Plan and Hands on Testing
Upload the attached protocol and search for the blowout commands with a position of -20 for the z value. See that it doesn't exist. Then upload it to PD and then export and look at the protocol again, the blowout commands with a position -20 for the z value should exist now.
qPCR Plating_v1_with Multi dispense_optimization.json
Changelog
Review requests
Risk assessment
low