Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Base unit and fork tests #2345

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Fix Base unit and fork tests #2345

merged 4 commits into from
Jan 9, 2025

Conversation

naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Jan 9, 2025

  • Fixes post the merge of the Yield Delegation changes
  • Added Base fork tests to the CI
  • Added Solidity files to prettier:check used by the CI

shahthepro
shahthepro previously approved these changes Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against b9837f3

sparrowDom
sparrowDom previously approved these changes Jan 9, 2025
@naddison36 naddison36 merged commit c02572b into master Jan 9, 2025
15 of 17 checks passed
@naddison36 naddison36 deleted the nicka/fix-base-tests branch January 9, 2025 11:50
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.09%. Comparing base (a559741) to head (b9837f3).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
contracts/contracts/token/OUSD.sol 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2345      +/-   ##
==========================================
+ Coverage   52.59%   53.09%   +0.50%     
==========================================
  Files          80       82       +2     
  Lines        4101     4196      +95     
  Branches     1079     1101      +22     
==========================================
+ Hits         2157     2228      +71     
- Misses       1941     1965      +24     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naddison36 naddison36 mentioned this pull request Jan 10, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants