Replaced mem::uninitialized with mem::MaybeUninit #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exact behavior of mem::uninitialized has been changed to cause panics, which causes problems for dependent libraries.
|
You're amazing! Thank you for this fix--literally just ran into this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue captures the problem pretty well: rust-lang/rust#73573. Change implemented here: rust-lang/rust#66059.
This was causing FunctionType::get_params to panic.
I've replaced mem::uninitialized with what should be the appropriate mem::MaybeUninit/assume_init pairs.
Oh, and I also changed try! for ? since rustc was complaining about the deprecated macro.
Open to feedback.