ROU-4828: Fix OnCellValueChange event returning newValue = oldValue when it is triggered via SetCellData

[OS-giulianasilva]

THIS PR STILL NEEDS TO BE PROPERLY VALIDATED.

This PR is for fix OnCellValueChange event returning newValue = oldValue when it is triggered via SetCellData

What was happening

• The OnCellValueChange is triggered after using the SetCellData returns the NewValue and OldValue parameters returned are the same.
• There is a not a good reason for it unless bad implementation.
• The validateCell method validates the cell and triggers the OnCellValueChange event with oldValue = newValue when the triggerOnCellValueChange parameter is true. This method is used in three places:
  • In the DropdownColumn’s _parentCellValueChangeHandler method. The validateCell is called with the triggerOnCellValueChange equals false and then another call is done to trigger the event using the ColumnEvents' trigger method.
  • In the ValidateCell’s API method where the validateCell’s triggerOnCellValueChange parameter depends on what is sent to the API. For this method, it makes sense that the oldValue = newValue, because the cell value does not change.
  • In the SetCellData’s API method where, like the ValidateCell’s API, the validateCell’s triggerOnCellValueChange parameter depends on what is sent to the API.

What was done

• Removed the part that triggers the OnCellValueChange event from the _parentCellValueChangeHandler method and use the one from the validateCell method
• Add a new parameter oldValue to the validateCell method to be used in the event trigger.
• When the oldValue is null/undefined and triggerOnCellValueChange = true , then oldValue needs to be equal newValue.
• When newValue is null/undefined, then we use the getCellData method.

Test Steps

Screenshots

(prefer animated gif)

Checklist

• tested locally
• documented the code
• clean all warnings and errors of eslint
• requires changes in OutSystems (if so, provide a module with changes)
• requires new sample page in OutSystems (if so, provide a module with changes)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud