ROU-4828: Fix OnCellValueChange event returning newValue = oldValue when it is triggered via SetCellData

src/OSFramework/DataGrid/Feature/ICellData.ts

@@ -1,6 +1,7 @@
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 namespace OSFramework.DataGrid.Feature {
 	export interface ICellData {
+		getCellData(rowNumber: number, column: OSFramework.DataGrid.Column.IColumn): unknown;
 		/**
 		 * Responsible for updating a specific cell -
 		 * This is needed in a case we wnat to update another column cell, for example when a cell content is denpendent on another.

src/OSFramework/DataGrid/Feature/IValidationMark.ts

@@ -17,7 +17,9 @@ namespace OSFramework.DataGrid.Feature {
 		validateCell(
 			rowNumber: number,
 			column: OSFramework.DataGrid.Column.IColumn,
-			triggerOnCellValueChange: boolean
+			triggerOnCellValueChange?: boolean,
+			currValue?: unknown,
+			oldValue?: unknown
 		): void;
 		validateRow(rowNumber: number): void;
 		// clearByRow(row: number): void;

src/OutSystems/GridAPI/Cell.ts

@@ -124,8 +124,9 @@ namespace OutSystems.GridAPI.Cells {
 				if (showDirtyMark) {
 					grid.features.dirtyMark.saveOriginalValue(rowIndex, column.providerIndex);
 				}
+				const oldValue = grid.features.cellData.getCellData(rowIndex, column);
 				grid.features.cellData.setCellData(rowIndex, column, value);
-				grid.features.validationMark.validateCell(rowIndex, column, triggerOnCellValueChange);
+				grid.features.validationMark.validateCell(rowIndex, column, triggerOnCellValueChange, value, oldValue);
 			},
 		});
 

src/Providers/DataGrid/Wijmo/Columns/DropdownColumn.ts

@@ -172,14 +172,7 @@ namespace Providers.DataGrid.Wijmo.Column {
 				// always clear the child cell when the parent changes
 				this.grid.provider.setCellData(rowNumber, this.provider.index, '', true);
 
-				this.grid.features.validationMark.validateCell(rowNumber, this, false);
-
-				this.columnEvents.trigger(
-					OSFramework.DataGrid.Event.Column.ColumnEventType.OnCellValueChange,
-					'',
-					originalValue,
-					rowNumber
-				);
+				this.grid.features.validationMark.validateCell(rowNumber, this, true, "", originalValue);
 			}
 		}
 

src/Providers/DataGrid/Wijmo/Features/CellData.ts

@@ -17,6 +17,10 @@ namespace Providers.DataGrid.Wijmo.Feature {
 			//
 		}
 
+		public getCellData(rowNumber: number, column: OSFramework.DataGrid.Column.IColumn): unknown {
+			return this._grid.provider.getCellData(rowNumber, column.provider.index, false);
+		}
+
 		public setCellData(rowNumber: number, column: OSFramework.DataGrid.Column.IColumn, value: string): void {
 			if (column.columnType === OSFramework.DataGrid.Enum.ColumnType.DateTime) {
 				value = this._grid.dataSource.trimSecondsFromDate(value);

src/Providers/DataGrid/Wijmo/Features/ValidationMark.ts

@@ -269,7 +269,7 @@ namespace Providers.DataGrid.Wijmo.Feature {
 			oldValue: any,
 			// eslint-disable-next-line @typescript-eslint/no-explicit-any
 			newValue: any
-		) {
+		) : void {
 			const column = this._grid.getColumn(columnUniqueID);
 
 			if (column !== undefined) {
@@ -600,17 +600,20 @@ namespace Providers.DataGrid.Wijmo.Feature {
 		public validateCell(
 			rowNumber: number,
 			column: OSFramework.DataGrid.Column.IColumn,
-			triggerOnCellValueChange = true
+			triggerOnCellValueChange: boolean,
+			currValue: unknown,
+			oldValue: unknown
 		): void {
 			// This method gets executed by an API. No values change in columns, so the current value and the original one (old value) are the same.
-			const currValue = this._grid.provider.getCellData(rowNumber, column.provider.index, false);
+			const newValue = currValue ?? this._grid.provider.getCellData(rowNumber, column.provider.index, false);
+			const previousValue = oldValue ?? newValue;
 
 			//If we decide not to trigger the column events we will skip this step
 			if (triggerOnCellValueChange) {
 				// Triggers the events of OnCellValueChange associated to a specific column in OS
-				this._triggerEventsFromColumn(rowNumber, column.uniqueId, currValue, currValue);
+				this._triggerEventsFromColumn(rowNumber, column.uniqueId, newValue, previousValue);
 			} else {
-				this._setCellStatus(column, rowNumber, currValue);
+				this._setCellStatus(column, rowNumber, newValue);
 			}
 		}