Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIH: Publish Aux Global Positon #24051

Merged
merged 3 commits into from
Dec 13, 2024
Merged

SIH: Publish Aux Global Positon #24051

merged 3 commits into from
Dec 13, 2024

Conversation

bresch
Copy link
Member

@bresch bresch commented Nov 28, 2024

Solved Problem

I need to test Aux Global Position (AGP) in sim.

Solution

Implement SensorAgpSim to publish AGP based on groundtruth data.

image

@bresch bresch added the Sim: SITL software in the loop simulation label Nov 28, 2024
@bresch bresch requested a review from dagar November 28, 2024 15:35
@bresch bresch self-assigned this Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: 8 byte (0 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%      +8  +0.0%      +8    .text
  +0.0%      +5  +0.0%      +5    ROMFS/nsh_romfsimg.c
  +0.0%      +3  +0.0%      +3    [section .text]
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -4  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
-0.0%     -28  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  -0.3%      -3  [ = ]       0    task/task_cancelpt.c
-0.0%      -8  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -8  [ = ]       0    [Unmapped]
+0.0%      +8  +0.0%      +8    TOTAL

px4_fmu-v6x [Total VM Diff: 0 byte (0 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -4  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
-0.0%     -20  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +0.4%      +5  [ = ]       0    task/task_cancelpt.c
-0.0%      -8  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.0%     +16  [ = ]       0    TOTAL

Updated: 2024-12-13T15:13:47

@bresch bresch force-pushed the pr_ekf2_ellipsoidal_sih branch from 3b401e2 to a984d0d Compare November 29, 2024 12:11
Base automatically changed from pr_ekf2_ellipsoidal_sih to main November 29, 2024 13:21
@bresch bresch marked this pull request as ready for review December 6, 2024 15:08
@bresch bresch merged commit 3941b19 into main Dec 13, 2024
60 checks passed
@bresch bresch deleted the pr-sih_agp branch December 13, 2024 16:40
@hamishwillee
Copy link
Contributor

This adds new parameters SIM_AGP_FAIL and SENS_EN_AGPSIM and

So I see AGP = Aux Global Position - so this provides you with a second source of global position so you can test estimators work OK?

Does this need further docs - say as a sub heading of https://docs.px4.io/main/en/simulation/#sitl-simulation-environment ?

I'd say if you want anyone else other than you to use this then probably a mention. But if it is very much internal, then maybe not.

@bresch ?

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/params-since-v1-15-20241204/42717/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sim: SITL software in the loop simulation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants