Remote ID in PX4 v1.14 #2627
Remote ID in PX4 v1.14 #2627
Conversation
en/peripherals/remote_id.md
Outdated
|
|
||
| ### Enable Remote ID | ||
|
|
||
| Enable Remote ID by [setting](../advanced_config/parameters.md#conditional-parameters) parameter [COM_ARM_ODID](#COM_ARM_ODID) to `2` (it is disabled by default). |
There was a problem hiding this comment.
Little nuance: under the hood this parameter is only allowing arming prevention, but to the user this would be effectively turning Remote ID "on", so it seems fine
There was a problem hiding this comment.
Thanks, I'll change it.
en/peripherals/remote_id.md
Outdated
| The UAV will then require `HEARTBEAT` messages from the Remote ID as a precondition for arming the UAV. | ||
| You can also set the parameter to `1` to warn but still allow arming without the Remote ID. | ||
|
|
||
| Once enabled, PX4 v1.14 streams these messages by default (in streaming modes: normal, onboard, usb, onboard low bandwidth): |
There was a problem hiding this comment.
We currently stream these messages regardless of whether the COM_ARM_ODID is set or not: https://github.com/PX4/PX4-Autopilot/blob/f000238987ce9d604bd7aa351d870d1c7c47464a/src/modules/mavlink/mavlink_main.cpp#L1518-L1519
Perhaps we should have either a generic remote ID enabler parameter or using COM_ARM_ODID, to not stream these messages when we aren't using Remote ID feature 🤔. I will leave a note on this in PX4/PX4-Autopilot#21777
There was a problem hiding this comment.
We certainly don't want to stream stuff if it is not needed. I know we have a pattern for streaming by default, and for requesting a stream. Do we have a pattern for enabling streaming based on a parameter or enabling a particular driver?
Most places we fly are going to need this, so default enabling probably not the end of the world.
There was a problem hiding this comment.
I have updated docs appropriately
en/peripherals/remote_id.md
Outdated
| The following message can be streamed on request (using [MAV_CMD_SET_MESSAGE_INTERVAL](https://mavlink.io/en/messages/common.html#MAV_CMD_SET_MESSAGE_INTERVAL)): | ||
|
|
||
| - [OPEN_DRONE_ID_BASIC_ID](https://mavlink.io/en/messages/common.html#OPEN_DRONE_ID_BASIC_ID) - UAV identity information (essentially a serial number) | ||
| - PX4 v1.14 specifies a serial number ([MAV_ODID_ID_TYPE_SERIAL_NUMBER](https://mavlink.io/en/messages/common.html#MAV_ODID_ID_TYPE_SERIAL_NUMBER)) but does not use the specified format (ANSI/CTA-2063 format). |
There was a problem hiding this comment.
Assuming Andrew's PR (PX4/PX4-Autopilot#21647) doesn't go into v1.14, this is a true statement.
Then, perhaps we could even elaborate further that we are using Board's GUID value, which is basically a unique device specifier like this (but if I'm not mistaken, for same CPUs, the same GUID will be shared, @davids5 do you have more info on this?) 🤔
Implementation details:
https://github.com/PX4/PX4-Autopilot/blob/f000238987ce9d604bd7aa351d870d1c7c47464a/src/modules/mavlink/streams/OPEN_DRONE_ID_BASIC_ID.hpp#L172-L174
There was a problem hiding this comment.
You said it wouldn't, and I believe you.
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-maintainers-call-july-18-2023/33189/1 |
|
No flaws found |
|
@junwoo091400 Thank you for your review. I have updated so it is now accurate for current state of play. Of course if PX4/PX4-Autopilot#21647 goes in then it would require an update. Merging now. |
* Remote ID in PX4 v1.14 * Make into standard format for easy extension * Update en/peripherals/remote_id.md Co-authored-by: Junwoo Hwang <[email protected]> * Address feedback --------- Co-authored-by: Junwoo Hwang <[email protected]>
This adds a page from Remote ID in PX4 v1.14. I wanted to capture that it is experimental, and exactly what you can expect right now.
I only added Cube ID as that is the only system I have had confirmed works with current main.
THoughts?
@mrpollo @junwoo091400 et al
PS Am requesting confirmation of Cube ID setup on https://discord.com/channels/1022170275984457759/1108437678871019530/1128846440702169188