Fix xrootd log level mapping bug and inherit from Pelican log level #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…og level This carries two fixes -- the first is for providing an xrootd log level that previously didn't have a definition, e.g. Logging.Origin.Http: trace. The new code should handle mapping that down if able, and up a level if needed The new code also uses Pelican's configured Logging.Level as the default for the other xrootd values. This lets us crank up logging all at once without having to toggle each directive individually, while still allowing for individual overrides if so desired.
jhiemstrawisc
added
bug
This was
linked to
issues
Feb 5, 2025
|
One problem I see is that because the default initialization is outside |
Sarthak pointed out my previous approach prevented the defaults from showing up in the dumped config JSON and through the config tool. This now sets default values in `config/config.go` such that the configured values populate in these locations. NOTE: This results in the _configured_ values showing up, but when a certain xrootd log param is undefined, it still maps up/down to the next best level. However, I don't think that's something the user needs to know about.
Saartank
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This carries two fixes -- the first is for providing an xrootd log level that previously didn't have a definition, e.g. Logging.Origin.Http: trace. The new code should handle mapping that down if able, and up a level if needed
The new code also uses Pelican's configured Logging.Level as the default for the other xrootd values. This lets us crank up logging all at once without having to toggle each directive individually, while still allowing for individual overrides if so desired.