Add Mf workaround #1149

Zemogiter · 2019-12-06T01:07:04Z

Description

A workaround for Media Foundation
https://github.com/z0z0z/mf-install
Needed for games that rely on it for ingame video and cutscenes. For example, benchmark videos in PC Building Simulator. After following instructions in the repo linked above, I can report they work just like on Windows now.

What works

Extracting the file, copying the dll files, setting dll overrides

What does not work

~~dll override adds "native" to the name of the overriden dll not where it supoused to be~~ fixed by Fix Wine plugin "Override DLL" #1152
no entries from mf.reg are applied to the registry. Regedit plugin shows no errors

What was not tested

Everything after above mentioned

Test

Operating system (and linux kernel version): Ubuntu 19.10
Hardware (GPU/CPU):i7-7700K,GTX 1080ti

Ready for review

Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
json-align and eslint run according to the documentation.
Codacy and travis checked.

Merged current master

Update the fork with changes from master fork.

Fix JSDoc (PhoenicisOrg#538)

Fork update

merge changes

Merging changes to the fork

Merging updates from master fork

Merging changes from master

Merge from master branch

Merge master fork

Updated the way virtual desktop plugin is used.

Merge master fork

Zemogiter · 2019-12-06T01:10:14Z

Output of eslint:

  79:68    error  Unnecessary escape character: \S  no-useless-escape
  79:77    error  Unnecessary escape character: \W  no-useless-escape
  79:82    error  Unnecessary escape character: \L  no-useless-escape
  79:576   error  Unnecessary escape character: \C  no-useless-escape
  79:582   error  Unnecessary escape character: \{  no-useless-escape
  79:675   error  Unnecessary escape character: \C  no-useless-escape
  79:681   error  Unnecessary escape character: \{  no-useless-escape
  79:720   error  Unnecessary escape character: \I  no-useless-escape
  79:795   error  Unnecessary escape character: \C  no-useless-escape
  79:801   error  Unnecessary escape character: \{  no-useless-escape
  79:888   error  Unnecessary escape character: \C  no-useless-escape
  79:894   error  Unnecessary escape character: \{  no-useless-escape
  79:933   error  Unnecessary escape character: \I  no-useless-escape
  79:1008  error  Unnecessary escape character: \C  no-useless-escape
  79:1014  error  Unnecessary escape character: \{  no-useless-escape
  79:1107  error  Unnecessary escape character: \C  no-useless-escape
  79:1113  error  Unnecessary escape character: \{  no-useless-escape
  79:1152  error  Unnecessary escape character: \I  no-useless-escape

Trailing space removal.

plata · 2019-12-12T17:05:48Z

Why does this PR contain Applications/Games/Heroes of Might & Magic IV/miniatures/main.png?

Zemogiter · 2019-12-13T09:29:22Z

I don't know. I've created separate branches for both Heroes 4 and this PR from master.

plata · 2019-12-16T17:36:43Z

Can you fix it?

Zemogiter · 2019-12-17T10:47:31Z

Done

Zemogiter · 2019-12-20T11:57:57Z

These escape characters are needed because reg entries must be in separate lines.

Zemogiter · 2019-12-24T18:59:18Z

OP was updated

Zemogiter · 2019-12-25T10:34:39Z

Tried referencing the .reg file inside mfWorkaroundDir but the same issue happens.

        const regeditFile = `${prefixDirectory}/mfWorkaround/mf-install-master/mf.reg`
        new Regedit(this.wine).patch(regeditFile);

Replaced the long and broken (at least according to Codacy) line of registry entries with reference to an already existing file.

madoar · 2019-12-29T10:16:37Z

By issue you mean that the .reg file is not modified?

madoar · 2019-12-29T10:18:57Z

@Zemogiter patch requires two parameters to work, please see:

scripts/Engines/Wine/Plugins/regedit/script.js

Lines 39 to 48 in 93403d4

    
           patch(patchContent, contentType) { 
        
               const content = this.convertPatchContent(patchContent, contentType); 
        
               const tmpFile = createTempFile("reg"); 
        
               writeToFile(tmpFile, content); 
        
               this.wine.run("regedit", [tmpFile], this.wine.prefixDirectory(), false, true); 
        
               return this; 
        
           }

Zemogiter · 2019-12-29T10:22:44Z

By issue I mean the registry entries from mf.reg are not in registry editor.

madoar · 2019-12-29T10:44:22Z

Engines/Wine/Verbs/mfWorkaround/script.js

+        }
+
+        const regeditFile = `${prefixDirectory}/mfWorkaround/mf-install-master/mf.reg`;
+        new Regedit(this.wine).patch(regeditFile);


Try new Regedit(this.wine).open(regeditFile);

Tried that. It did not fix the issue.

patch is definitely wrong. See my argument above.

What "error" do you get when you use open?

Thats the thing. No error in terminal window in either patch or open.

One parameter should work (the type can be undefined). I think it should be

new Regedit(this.wine).patch(cat(regeditFile));

Regedit#patch writes the patchContent to a file. So in your case, it tries to patch the registry with the string "${prefixDirectory}/mfWorkaround/mf-install-master/mf.reg" instead of the content of that file.

In this case it cannot be a Phoenicis issue. Maybe something is wrong in the file?

@plata just tried it on plain Wine and the whole .reg file is in the registry editor.

Have you tried other scripts that make use of Regedit? Do they work for you?

@madoar yes they do

Strange. If Phoenicis uses the same command line as plain Wine, how can it be different...

Engines/Wine/Verbs/mfWorkaround/script.js

Codacy Fix

Engines/Wine/Verbs/mfWorkaround/script.js

Comment removal

madoar · 2020-01-03T11:36:25Z

Has the regedit problem be solved or is it still work in progress?

Zemogiter · 2020-01-03T12:55:21Z

@madoar still work in progress

Included the second .reg file.

Zemogiter added 27 commits March 27, 2018 22:15

Merge pull request #1 from PhoenicisOrg/master

254649c

Merged current master

Merge pull request #3 from PhoenicisOrg/master

63f898c

Update the fork with changes from master fork.

Merge pull request #4 from PhoenicisOrg/master

71cd3d8

Fix JSDoc (PhoenicisOrg#538)

Merge pull request #5 from PhoenicisOrg/master

60c3cb5

Fork update

Merge pull request #6 from PhoenicisOrg/master

69e7bf2

merge changes

Merge pull request #7 from PhoenicisOrg/master

5bf56fe

Merging changes to the fork

Merge pull request #8 from PhoenicisOrg/master

1c4fe31

Merging updates from master fork

Merge pull request #9 from PhoenicisOrg/master

66bd276

Merging changes from master

Add files via upload

1791c28

Merge pull request #22 from PhoenicisOrg/master

9d473d3

Merge from master branch

Merge pull request #23 from PhoenicisOrg/master

afeb994

Merge master fork

Update script.js

25b45d5

Updated the way virtual desktop plugin is used.

Update script.js

43932a3

Update script.js

8db0264

Update script.js

2cfd676

Update script.js

8b7a82a

Update script.js

b1b30ac

Update script.js

c21fb41

Merge pull request #24 from PhoenicisOrg/master

923f809

Merge master fork

Merge pull request #30 from PhoenicisOrg/master

d3b3b61

Merge master fork

Add files via upload

dc204af

Update script.js

5bc1ecc

Add files via upload

a14bba6

Delete script.js

184a82f

Delete script.json

efa743f

Delete application.json

a0a1cd0

Update script.js

db1fc7b

Zemogiter added 2 commits December 6, 2019 10:27

Update script.json

d877dde

Update script.js

f1bb146

Trailing space removal.

Delete main.png

c055748

madoar added the WIP Work in progress label Dec 23, 2019

Update script.js

bdc3a58

Replaced the long and broken (at least according to Codacy) line of registry entries with reference to an already existing file.

Zemogiter mentioned this pull request Dec 29, 2019

Check Plugin Scripts #1151

Open

18 tasks

madoar reviewed Dec 29, 2019

View reviewed changes

madoar requested changes Jan 2, 2020

View reviewed changes

Zemogiter added 2 commits January 2, 2020 16:14

Update script.js

71b7440

Update script.js

1e022ba

Codacy Fix

madoar requested changes Jan 3, 2020

View reviewed changes

Engines/Wine/Verbs/mfWorkaround/script.js Outdated Show resolved Hide resolved

Update script.js

a9e3e1e

Comment removal

Update script.js

2bb2a27

Included the second .reg file.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Mf workaround #1149

Add Mf workaround #1149

Zemogiter commented Dec 6, 2019 •

edited

Loading

Zemogiter commented Dec 6, 2019

plata commented Dec 12, 2019

Zemogiter commented Dec 13, 2019

plata commented Dec 16, 2019

Zemogiter commented Dec 17, 2019

Zemogiter commented Dec 20, 2019 •

edited

Loading

Zemogiter commented Dec 24, 2019

Zemogiter commented Dec 25, 2019 •

edited

Loading

madoar commented Dec 29, 2019

madoar commented Dec 29, 2019

Zemogiter commented Dec 29, 2019

madoar Dec 29, 2019

Zemogiter Dec 29, 2019

madoar Dec 29, 2019

Zemogiter Dec 29, 2019

plata Dec 29, 2019

plata Dec 30, 2019

Zemogiter Dec 30, 2019

madoar Dec 30, 2019

Zemogiter Dec 30, 2019

plata Dec 30, 2019 •

edited

Loading

madoar commented Jan 3, 2020

Zemogiter commented Jan 3, 2020

Add Mf workaround #1149

Are you sure you want to change the base?

Add Mf workaround #1149

Conversation

Zemogiter commented Dec 6, 2019 • edited Loading

Description

What works

What does not work

What was not tested

Test

Ready for review

Zemogiter commented Dec 6, 2019

plata commented Dec 12, 2019

Zemogiter commented Dec 13, 2019

plata commented Dec 16, 2019

Zemogiter commented Dec 17, 2019

Zemogiter commented Dec 20, 2019 • edited Loading

Zemogiter commented Dec 24, 2019

Zemogiter commented Dec 25, 2019 • edited Loading

madoar commented Dec 29, 2019

madoar commented Dec 29, 2019

Zemogiter commented Dec 29, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

plata Dec 30, 2019 • edited Loading

Choose a reason for hiding this comment

madoar commented Jan 3, 2020

Zemogiter commented Jan 3, 2020

Zemogiter commented Dec 6, 2019 •

edited

Loading

Zemogiter commented Dec 20, 2019 •

edited

Loading

Zemogiter commented Dec 25, 2019 •

edited

Loading

plata Dec 30, 2019 •

edited

Loading